Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #7609

closed

pulpcore-selinux's Makefile is incomplete and unused

Added by mdepaulo@redhat.com over 3 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
mdepaulo@redhat.com
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
SELinux
Sprint:
Sprint 82
Quarter:
Q4-2020

Description

The repo's makefile is not used: https://github.com/pulp/pulpcore-selinux/blob/master/Makefile

The README, pulp_installer PR, and katello RPM package all use the makefile from selinux-policy-devel instead: /usr/share/selinux/devel/Makefile

Therefore, the repo's Makefile should be either removed, or fixed.

Actions
Copy link
 #1

Updated by mdepaulo@redhat.com over 3 years ago

  • Assignee set to mdepaulo@redhat.com
Actions
Copy link
 #2

Updated by fao89 over 3 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 82
  • Quarter set to Q4-2020

Added by Mike DePaulo over 3 years ago

Revision 07cc4140 | View on GitHub

Problem: Makefile is incomplete and unused

Solution: Remove it

It was never updated for 1.1 anyway.

The build instructions, which include using an SELinux Makefile, are in README.md.

fixes: #7609 https://pulp.plan.io/issues/7609 pulpcore-selinux's Makefile is incomplete and unused

Actions
Copy link
 #3

Updated by Anonymous over 3 years ago

  • Status changed from NEW to MODIFIED
Actions
Copy link
 #4

Updated by mdepaulo@redhat.com over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Fix released in 1.1.1: https://github.com/pulp/pulpcore-selinux/releases/tag/1.1.1

I just removed the Makefile. I concluded that since it wasn't upgraded by Zdenek for version 1.1 (EL8 support, new policy module, etc) in addition to not being used/referenced anywhere, it's best to just remove it.

Actions
Send by e-mail Copy link

Also available in: Atom PDF