"commit check" should allow references to issues that are outside of the project
It makes sense for the commit check to require the any issues being closed or fixed by a commit to be in the same project, but we shouldn't disallow simple references ("re", "ref" tag) to issues from other projects.
It's still semi-common for fixes of plugin issues to require changes to pulpcore and on rare occasions vice-versa.
#3 Updated by daviddavis 4 months ago
Personally, when I am working on a plugin change that requires a change in pulpcore, I always file an issue against pulpcore. This helps track changes in redmine and associates these changes with milestones. Also, it forces me to create a changelog entry so that other plugin authors are aware of the change.
If we do decide to disable the project check for
ref issues, then we'll also have to update changelog check that checks that all commits (besides
[noissue] ones) have changelog entries. We could disable this check for
ref issues. However, we should still validate that if someone adds a changelog that it still matches the project as the release code validates changelog issues are associated with the project milestone. This would make the validation more complex but it's doable.
Please register to edit this issue