Project

Profile

Help

Issue #7548

"commit check" should allow references to issues that are outside of the project

Added by dalley 8 months ago. Updated 7 months ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
CI/CD, Plugin Template
Sprint:
Quarter:

Description

It makes sense for the commit check to require the any issues being closed or fixed by a commit to be in the same project, but we shouldn't disallow simple references ("re", "ref" tag) to issues from other projects.

It's still semi-common for fixes of plugin issues to require changes to pulpcore and on rare occasions vice-versa.


Related issues

Related to Pulp - Issue #6905: The pr processor sets issues to POST that are associated with "ref" (eg "ref #1234")NEW<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by dalley 8 months ago

  • Project changed from Migration Plugin to Pulp

#2 Updated by dalley 8 months ago

  • Related to Issue #6905: The pr processor sets issues to POST that are associated with "ref" (eg "ref #1234") added

#3 Updated by daviddavis 8 months ago

Personally, when I am working on a plugin change that requires a change in pulpcore, I always file an issue against pulpcore. This helps track changes in redmine and associates these changes with milestones. Also, it forces me to create a changelog entry so that other plugin authors are aware of the change.

If we do decide to disable the project check for ref issues, then we'll also have to update changelog check that checks that all commits (besides [noissue] ones) have changelog entries. We could disable this check for ref issues. However, we should still validate that if someone adds a changelog that it still matches the project as the release code validates changelog issues are associated with the project milestone. This would make the validation more complex but it's doable.

#4 Updated by fao89 7 months ago

  • Status changed from NEW to CLOSED - WONTFIX

it was decided it is better to have changelog entries on each plugin

Please register to edit this issue

Also available in: Atom PDF