Project

Profile

Help

Issue #7440

closed

Orphan cleanup does not remove distribution tree content

Added by daviddavis about 4 years ago. Updated about 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 82
Quarter:

Description

Steps to reproduce

  1. Sync a repo with a distribution tree such as https://fixtures.pulpproject.org/rpm-distribution-tree/
  2. Delete the repo and run orphan cleanup
  3. Go to an endpoint such as /pulp/api/v3/content/rpm/packages/ and observe that there's still content in the database

I did some debugging and it turns out the subrepos are still in the database and they're holding on to content.

This came up while trying to update our pulp_rpm tests to use the new rpm-distribution-tree fixture. Content sticks around which presents a problem for later tests that try to upload content and then hit a duplicate error. See the test failures here: https://github.com/pulp/pulp_rpm/pull/1832


Related issues

Blocks RPM Support - Task #7040: The kickstart fixture doesn't include packages/errata/etcCLOSED - CURRENTRELEASEdaviddavis

Actions
Actions #1

Updated by daviddavis about 4 years ago

  • Description updated (diff)
Actions #2

Updated by daviddavis about 4 years ago

  • Blocks Task #7040: The kickstart fixture doesn't include packages/errata/etc added
Actions #3

Updated by daviddavis about 4 years ago

Talking with ttereshc, it sounds like the best solution is to add a post_delete hook to clean up subrepos and content for distribution trees.

Actions #4

Updated by daviddavis about 4 years ago

I believe we also need a migration to clean up orphaned subrepos.

Actions #5

Updated by ttereshc about 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc
  • Sprint set to Sprint 80
Actions #6

Updated by pulpbot about 4 years ago

  • Status changed from ASSIGNED to POST
Actions #7

Updated by ttereshc about 4 years ago

  • Triaged changed from No to Yes
Actions #8

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 80 to Sprint 81
Actions #9

Updated by rchan about 4 years ago

  • Sprint changed from Sprint 81 to Sprint 82

Added by ttereshc about 4 years ago

Revision d2dd79d0 | View on GitHub

Remove subrepos during distribution tree removal.

Cleanup orphaned subrepos in a migration.

closes #7440 https://pulp.plan.io/issues/7440 [nocoverage]

Actions #10

Updated by ttereshc about 4 years ago

  • Status changed from POST to MODIFIED
Actions #11

Updated by ttereshc about 4 years ago

  • Sprint/Milestone set to 3.7.0
Actions #12

Updated by pulpbot about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF