Project

Profile

Help

Issue #7248

Copy API code still uses packagegroup relation for Package Environment

Added by sajha 4 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Sprint 78
Quarter:

Description

A call to copy content between repositories hits this line which seems like an issue given the package group relation has been dropped from the Package Environment model. https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/tasks/copy.py#L94

for env_package_group in packageenvironment.packagegroups:

Logs:

pulp_tasks:
- pulp_href: "/pulp/api/v3/tasks/be428f2e-20d9-42bb-ac69-741a9e1b15c0/"
  pulp_created: '2020-07-31T01:36:04.455+00:00'
  state: completed
  name: pulp_rpm.app.tasks.copy.copy_content
  started_at: '2020-07-31T01:36:04.670+00:00'
  finished_at: '2020-07-31T01:36:34.115+00:00'
  worker: "/pulp/api/v3/workers/18f81132-6cb9-4ea0-9b49-06a8178bb039/"
  child_tasks: []
  progress_reports: []
  created_resources:
  - "/pulp/api/v3/repositories/rpm/rpm/bba3e5d7-8ca9-4d04-93d9-febbe042c31d/versions/1/"
  reserved_resources_record:
  - "/pulp/api/v3/repositories/rpm/rpm/371a44d3-45a2-43c2-a0c5-850610276de2/"
  - "/pulp/api/v3/repositories/rpm/rpm/bba3e5d7-8ca9-4d04-93d9-febbe042c31d/"
- pulp_href: "/pulp/api/v3/tasks/51cab929-7ddf-4d0f-81ce-dc5f6f92a8a5/"
  pulp_created: '2020-07-31T01:36:04.563+00:00'
  state: failed
  name: pulp_rpm.app.tasks.copy.copy_content
  started_at: '2020-07-31T01:36:34.317+00:00'
  finished_at: '2020-07-31T01:36:34.365+00:00'
  error:
    traceback: |2
        File "/usr/lib/python3.6/site-packages/rq/worker.py", line 883, in perform_job
          rv = job.perform()
        File "/usr/lib/python3.6/site-packages/rq/job.py", line 645, in perform
          self._result = self._execute()
        File "/usr/lib/python3.6/site-packages/rq/job.py", line 651, in _execute
          return self.func(*self.args, **self.kwargs)
        File "/usr/lib64/python3.6/contextlib.py", line 52, in inner
          return func(*args, **kwds)
        File "/usr/lib/python3.6/site-packages/pulp_rpm/app/tasks/copy.py", line 167, in copy_content
          content_to_copy |= find_children_of_content(content_to_copy, source_repo_version)
        File "/usr/lib/python3.6/site-packages/pulp_rpm/app/tasks/copy.py", line 94, in find_children_of_content
          for env_package_group in packageenvironment.packagegroups:
    description: "'PackageEnvironment' object has no attribute 'packagegroups'"
  worker: "/pulp/api/v3/workers/18f81132-6cb9-4ea0-9b49-06a8178bb039/"
  child_tasks: []
  progress_reports: []
  created_resources: []
  reserved_resources_record:
  - "/pulp/api/v3/repositories/rpm/rpm/371a44d3-45a2-43c2-a0c5-850610276de2/"
  - "/pulp/api/v3/repositories/rpm/rpm/bba3e5d7-8ca9-4d04-93d9-febbe042c31d/"
poll_attempts:
  total: 18
  failed: 1

Associated revisions

Revision e1bed54d View on GitHub
Added by ppicka 4 months ago

PkgEnv copy depsolving bugfix

PkgEnv copy depsolving still used removed relations. Now using group_ids and option_ids.

closes: #7248 https://pulp.plan.io/issues/7248

[nocoverage]

To test this new fixtures needed. Issue filled: https://pulp.plan.io/issues/7253

Revision 742ee1cc View on GitHub
Added by ppicka 4 months ago

PkgEnv copy depsolving bugfix

PkgEnv copy depsolving still used removed relations. Now using group_ids and option_ids.

closes: #7248 https://pulp.plan.io/issues/7248

[nocoverage]

To test this new fixtures needed. Issue filled: https://pulp.plan.io/issues/7253

(cherry picked from commit e1bed54db779d20b46d03fffd828fda987fea384)

History

#1 Updated by ttereshc 4 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 78

#2 Updated by ppicka 4 months ago

  • Assignee set to ppicka

#3 Updated by sajha 4 months ago

  • Tags Katello added

#4 Updated by ppicka 4 months ago

  • Status changed from NEW to ASSIGNED

#5 Updated by ppicka 4 months ago

  • Status changed from ASSIGNED to POST

#6 Updated by ppicka 4 months ago

  • Status changed from POST to MODIFIED

#7 Updated by ttereshc 4 months ago

  • Sprint/Milestone set to 3.5.1

#8 Updated by pulpbot 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF