https://pulp.plan.io/https://pulp.plan.io/favicon.ico2020-07-28T15:51:39ZPulpRPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=601492020-07-28T15:51:39Zttereshcttereshc@redhat.com
<ul></ul><p>It seems to happen because <a href="https://github.com/pulp/pulpcore/blob/master/pulpcore/plugin/stages/declarative_version.py#L145" class="external">the mirror implementation from the pulpcore</a> is used which is unaware of the RPM specific <code>optimize</code> option which does not add any content to a new incomplete repo version.</p>
<p>Possible solutions:</p>
<ol>
<li>have custom implementation of <code>DeclarativeVersion.create</code> in the plugin</li>
<li>have plugin input in the pulpcore when deciding whether to add the content unassociation step or not</li>
<li>add existing content to the incomplete repo version, so it would be clear that content is there and there is just nothing to remove because it's the same.</li>
<li>anything else?</li>
</ol> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=601562020-07-28T18:42:54Zbmbouterbmbouter@redhat.com
<ul></ul><p>I looked over the optimize_sync code and I recommend moving <a href="https://github.com/pulp/pulp_rpm/blob/master/pulp_rpm/app/tasks/synchronizing.py#L360-L380" class="external">it</a> out of RpmFirstStage and into the task code called before DeclarativeVersion.create() is even called. This will cause the pipeline never to start. From an efficiency perspective since no DeclarativeContent is emitted down the pipeline there is no concurrency opportunity so handling that synchronously earlier in the code should be the same from an efficiency perspective.</p> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=603182020-08-03T14:53:52Zttereshcttereshc@redhat.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li><li><strong>Sprint</strong> set to <i>Sprint 78</i></li></ul> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=604412020-08-05T15:21:50Zttereshcttereshc@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>ttereshc</i></li></ul> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=604562020-08-05T20:50:58Zpulpbot
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li></ul><p>PR: <a href="https://github.com/pulp/pulp_rpm/pull/1797" class="external">https://github.com/pulp/pulp_rpm/pull/1797</a></p> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=604952020-08-07T11:38:26Zttereshcttereshc@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Handle mirror=True and optimize=True correctly. Sub_repo sync is now also optimized when possibl..." href="https://pulp.plan.io/projects/pulp_rpm/repository/9/revisions/057af882f23deef6170ea683bfb15261460d9328">057af882f23deef6170ea683bfb15261460d9328</a>.</p> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=607182020-08-11T18:13:45Zttereshcttereshc@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>3.5.1</i></li></ul> RPM Support - Issue #7228: Optimized sync with mirror set to true unassociates all content units and creates an empty repository versionhttps://pulp.plan.io/issues/7228?journal_id=607682020-08-12T14:55:59Zpulpbot
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul>