Project

Profile

Help

Issue #7149

closed

Do not share request session with multiple threads

Added by jluza almost 4 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Nectar:
Platform Release:
Target Release - Nectar:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

When requests.Session is shared with multiple threads Retry instance effectively retires for all threads together which can result in situation where requested url is actually not retried beause retry counter is depleted by another threads To fix that Session object should be create for every single thread

Added by jluza almost 4 years ago

Revision 061751a6 | View on GitHub

Do not share requests session within multiple threads

If one session object is shared within multiple threads, it can happen it ran out of retries even for new connections which is not desired. Constant number of retries should be applied to every request. In this commit session object is created per every worker thread

Fixes #7149.

Actions #1

Updated by daviddavis almost 4 years ago

  • Status changed from NEW to POST
  • Assignee set to jluza
Actions #2

Updated by jluza almost 4 years ago

  • Status changed from POST to MODIFIED
Actions #3

Updated by ttereshc over 3 years ago

  • Project changed from Pulp to Nectar
Actions #4

Updated by ttereshc over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF