https://pulp.plan.io/https://pulp.plan.io/favicon.ico2015-02-28T23:23:40ZPulpPulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15912015-02-28T23:23:40Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>this commit introduced the issue <a href="https://github.com/pulp/pulp/commit/8e351dc49345b2f022f1e26b0b39c5227609a74a" class="external">https://github.com/pulp/pulp/commit/8e351dc49345b2f022f1e26b0b39c5227609a74a</a></p>
<p>Deletion of repo_group and consumer_group should be a synchronous call, at least it was so time ago. Plus docs confirm that also <a href="http://pulp.readthedocs.org/en/latest/dev-guide/integration/rest-api/repo/groups/cud.html#delete-a-repository-group" class="external">http://pulp.readthedocs.org/en/latest/dev-guide/integration/rest-api/repo/groups/cud.html#delete-a-repository-group</a></p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c1" class="external">Bugzilla #1192177 comment 1</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15922015-02-28T23:23:40Zdkliban@redhat.com
<ul></ul><p>Why does a repo group need to have a working directory?</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c2" class="external">Bugzilla #1192177 comment 2</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15932015-02-28T23:23:41Zbmbouterbmbouter@redhat.com
<ul></ul><p>I can't think of why it would need a working directory. If we can remove the manager's usage of the working directory that would be the best fix for this.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c3" class="external">Bugzilla #1192177 comment 3</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15942015-02-28T23:23:42Zdkliban@redhat.com
<ul></ul><p>I am going to fix this bug, by removing the code that tries to delete the working directory. Now that the working directories are cleaned up after tasks finish running, I don't think it's necessary to worry about deleting them elsewhere.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c4" class="external">Bugzilla #1192177 comment 4</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15952015-02-28T23:23:43Zamacdona@redhat.comaustin@redhat.com
<ul></ul><p>Agreed. And after the working directory code is removed, the bug should be modified to make this delete asynchronous and given a target of 3.0.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c5" class="external">Bugzilla #1192177 comment 5</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15962015-02-28T23:23:44Zbmbouterbmbouter@redhat.com
<ul></ul><p>I don't think the goal is to make delete asynchronous. It can be a synchronous since its just some simple mongo bookkeeping. It should return very quickly. I recommend fixing it as discussed and then sending it to QA.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c6" class="external">Bugzilla #1192177 comment 6</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=15972015-02-28T23:23:45Zdkliban@redhat.com
<ul></ul><p><a href="https://github.com/pulp/pulp/pull/1641" class="external">https://github.com/pulp/pulp/pull/1641</a></p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1192177#c7" class="external">Bugzilla #1192177 comment 7</a> +</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=17202015-03-02T19:44:43Zbcourtbcourt@redhat.com
<ul></ul><p>If a repo group supports custom distributors, then deleting the repo group could involve updates to the filesystem which probably should not be done synchronously.</p> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=17832015-03-02T22:52:42Zbmbouterbmbouter@redhat.com
<ul><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li><li><strong>Severity</strong> set to <i>Medium</i></li></ul> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=27372015-03-20T19:15:39Zbmbouterbmbouter@redhat.com
<ul><li><strong>Severity</strong> changed from <i>Medium</i> to <i>2. Medium</i></li></ul> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=34892015-04-17T20:23:21Zdkliban@redhat.com
<ul><li><strong>Platform Release</strong> set to <i>2.7.0</i></li></ul> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=49282015-06-15T18:34:36Zdkliban@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>5</i></li></ul> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=53502015-07-07T16:14:21Zigulina@redhat.comigulina@redhat.com
<ul><li><strong>Status</strong> changed from <i>5</i> to <i>6</i></li></ul><pre><code>>>rpm -qa pulp-server
pulp-server-2.7.0-0.4.beta.el7.noarch
</code></pre>
<p>Deleting a group without members:</p>
<pre><code>>> pulp-admin repo group create --group-id banda
Repository Group [banda] successfully created
>> pulp-admin repo group delete --group-id banda
Repository group [banda] successfully deleted
</code></pre>
<p>Deleting nonempty group:</p>
<pre><code>pulp-admin repo group list
+----------------------------------------------------------------------+
Repository Groups
+----------------------------------------------------------------------+
Id: zoo_banda
Display Name: None
Description: None
Repo Ids: zoopark, panda
Notes:
>> pulp-admin repo group delete --group-id zoo_banda
Repository group [zoo_banda] successfully deleted
</code></pre>
<p>Deleting nonexisting group:</p>
<pre><code>>> pulp-admin repo group delete --group-id no_such_group
Repository group [no_such_group] does not exist on the server
</code></pre>
<p>And one more test:</p>
<pre><code>>> pulp-admin repo group create --group-id zoo_group
Repository Group [zoo_group] successfully created
>> pulp-admin repo group members add --group-id zoo_group --all
Successfully added members to repository group [zoo_group]
>> pulp-admin rpm repo delete --repo-id panda
This command may be exited via ctrl+c without affecting the request.
[\]
Running...
Repository [panda] successfully deleted
>> pulp-admin repo group delete --group-id zoo_group
Repository group [zoo_group] successfully deleted
</code></pre>
<p>And API:</p>
<pre><code>>> pulp-admin repo group create --group-id my_repo_group
Repository Group [my_repo_group] successfully created
>> curl -i -H \"Accept: application/json\" -X DELETE -k -u admin:admin 'https://localhost/pulp/api/v2/repo_groups/my_repo_group/'
curl: (6) Could not resolve host: application; Name or service not known
HTTP/1.1 200 OK
Date: Tue, 07 Jul 2015 16:13:14 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux) OpenSSL/1.0.1e-fips mod_wsgi/3.4 Python/2.7.5
Content-Length: 4
Content-Type: application/json
null
>> pulp-admin repo group list
+----------------------------------------------------------------------+
Repository Groups
+----------------------------------------------------------------------+
No repository groups found
</code></pre> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=69092015-11-06T19:35:20Zamacdona@redhat.comaustin@redhat.com
<ul><li><strong>Status</strong> changed from <i>6</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> Pulp - Issue #696: PulpCodedException raised when deleting a repo grouphttps://pulp.plan.io/issues/696?journal_id=401502019-04-15T21:05:49Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>