Project

Profile

Help

Issue #689

closed

The worker systemd units did not get updated to include SIGQUIT

Added by rbarlow about 9 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
Master
Platform Release:
2.6.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Description of problem:
I believe that our systemd workers will not receive SIGQUIT when they are stopped, as SIGQUIT was placed on the wrong unit. The pulp_workers.service file[0] received the KillSignal=SIGQUIT setting, but it should have instead been included in the _WORKER_TEMPLATE[1].

Version-Release number of selected component (if applicable):
2.5

How reproducible:
Every time.

Steps to Reproduce:
1. $ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
2. $ grep KillSignal < /run/systemd/system/pulp_worker-*.service

Actual results:
$ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
KillSignal=SIGQUIT
$ grep KillSignal < /run/systemd/system/pulp_worker-*.service

Expected results:
$ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
$ grep KillSignal < /run/systemd/system/pulp_worker-*.service
KillSignal=SIGQUIT
KillSignal=SIGQUIT
KillSignal=SIGQUIT
KillSignal=SIGQUIT
(If you have four worker services.)

Additional info:
[0] https://github.com/pulp/pulp/blob/master/server/usr/lib/systemd/system/pulp_workers.service
[1] https://github.com/pulp/pulp/blob/master/server/pulp/server/async/manage_workers.py#L27

+ This bug was cloned from Bugzilla Bug #1190756 +

Also available in: Atom PDF