Issue #689
closed
The worker systemd units did not get updated to include SIGQUIT
Description
Description of problem:
I believe that our systemd workers will not receive SIGQUIT when they are stopped, as SIGQUIT was placed on the wrong unit. The pulp_workers.service file[0] received the KillSignal=SIGQUIT setting, but it should have instead been included in the _WORKER_TEMPLATE[1].
Version-Release number of selected component (if applicable):
2.5
How reproducible:
Every time.
Steps to Reproduce:
1. $ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
2. $ grep KillSignal < /run/systemd/system/pulp_worker-*.service
Actual results:
$ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
KillSignal=SIGQUIT
$ grep KillSignal < /run/systemd/system/pulp_worker-*.service
Expected results:
$ grep KillSignal < /usr/lib/systemd/system/pulp_workers.service
$ grep KillSignal < /run/systemd/system/pulp_worker-*.service
KillSignal=SIGQUIT
KillSignal=SIGQUIT
KillSignal=SIGQUIT
KillSignal=SIGQUIT
(If you have four worker services.)
Additional info:
[0] https://github.com/pulp/pulp/blob/master/server/usr/lib/systemd/system/pulp_workers.service
[1] https://github.com/pulp/pulp/blob/master/server/pulp/server/async/manage_workers.py#L27
+ This bug was cloned from Bugzilla Bug #1190756 +
Updated by rbarlow about 8 years ago
https://github.com/pulp/pulp/pull/1622
+ This comment was cloned from Bugzilla #1190756 comment 1 +
Updated by cduryee about 8 years ago
2.6.0-0.7.beta
+ This comment was cloned from Bugzilla #1190756 comment 2 +
Updated by igulina@redhat.com about 8 years ago
rpm -qa pulp-server
pulp-server-2.6.0-0.7.beta.fc20.noarch
grep "CONCUR" /etc/default/pulp_workers
PULP_CONCURRENCY=4
service pulp_workers stop
Redirecting to /bin/systemctl stop pulp_workers.service
grep KillSignal < /run/systemd/system/pulp_worker-*.service
bash: /run/systemd/system/pulp_worker*.service: ambiguous redirect
grep KillSignal /run/systemd/system/pulp_worker-*.service
/run/systemd/system/pulp_worker-0.service:KillSignal=SIGQUIT
/run/systemd/system/pulp_worker-1.service:KillSignal=SIGQUIT
/run/systemd/system/pulp_worker-2.service:KillSignal=SIGQUIT
/run/systemd/system/pulp_worker-3.service:KillSignal=SIGQUIT
grep KillSignal /usr/lib/systemd/system/pulp_workers.service
#
+ This comment was cloned from Bugzilla #1190756 comment 3 +
Updated by rbarlow almost 8 years ago
- Status changed from 6 to CLOSED - CURRENTRELEASE
.