Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #6863

closed

Validate whitelist/blacklist package specifiers when Remote is created/updated

Added by gerrod almost 4 years ago. Updated about 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Python:
Platform Release:
Target Release - Python:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Two tests in test_crud_remotes.py that check to make sure the user can't update a remote's include/exclude name specifier to an empty string are both failing. The user is allowed to perform this illegal operation and Pulp does not give an error. The name field in ProjectSpecifierSerializer should check that the updated name is not blank and raise an exception, but it doesn't. Both tests are currently skipped to avoid them failing.

We should likely use this method from the requirements-parser library on PyPI to do this validation: https://requirements-parser.readthedocs.io/en/latest/lowlevel.html#requirements.requirement.Requirement.parse

Actions
Copy link
 #1

Updated by dalley almost 4 years ago

  • Subject changed from Updating a remote include/exclude with an invalid specificier name doesn't error to Validate whitelist/blacklist package specifiers when Remote is created/updated
  • Description updated (diff)
Actions
Copy link
 #2

Updated by gerrod about 3 years ago

  • Status changed from NEW to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF