Project

Profile

Help

Issue #6863

Validate whitelist/blacklist package specifiers when Remote is created/updated

Added by gerrod 4 months ago. Updated 4 months ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Python:
Platform Release:
Target Release - Python:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Two tests in test_crud_remotes.py that check to make sure the user can't update a remote's include/exclude name specifier to an empty string are both failing. The user is allowed to perform this illegal operation and Pulp does not give an error. The name field in ProjectSpecifierSerializer should check that the updated name is not blank and raise an exception, but it doesn't. Both tests are currently skipped to avoid them failing.

We should likely use this method from the requirements-parser library on PyPI to do this validation: https://requirements-parser.readthedocs.io/en/latest/lowlevel.html#requirements.requirement.Requirement.parse

History

#1 Updated by dalley 4 months ago

  • Subject changed from Updating a remote include/exclude with an invalid specificier name doesn't error to Validate whitelist/blacklist package specifiers when Remote is created/updated
  • Description updated (diff)

Please register to edit this issue

Also available in: Atom PDF