Project

Profile

Help

Issue #620

closed

admin.conf default for host value in [server] does not contain an accurate default

Added by bmbouter about 9 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.5
Platform Release:
2.7.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

The admin.conf contains this section:

[server]

  1. host:

We tell our users that the commented out values are the defaults so I expect host to be set to '' by default. This is especially true after fixing [0].

In looking in pulp/client_admin/pulp/client/admin/config.py I see this code:

'host': socket.gethostname()

This causes 'host' to unexpectedly default to socket.gethostname(). I expect defaults are not looked up dynamically at runtime, and that the values commented out in the admin.conf file to be the actual default. I think using localhost as a static default, and removing the socket.gethostname() would be the best.

[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1161205

+ This bug was cloned from Bugzilla Bug #1165346 +

Also available in: Atom PDF