Issue #601
closed
repo will be updated if a wrong repo type is specified
Description
Description of problem:
We can specify the wrong type of the updated repo, and it's still will be updated.
Version-Release number of selected component (if applicable):
rpm -qa | grep pulp-server
pulp-server-2.5.0-0.14.beta.el6.noarch
How reproducible:
always
Steps to Reproduce:
pulp-admin docker repo list
--------------------------------------------------------------------
Docker Repositories
--------------------------------------------------------------------
Id: zoo
Display Name: zoo
Description: None
Content Unit Counts:
Id: woo.doo
Display Name: woo.doo
Description: None
Content Unit Counts:
Id: .
Display Name: .
Description: None
Content Unit Counts:
pulp-admin rpm repo list
--------------------------------------------------------------------
RPM Repositories
--------------------------------------------------------------------
Id: gena
Display Name: gena
Description:
Content Unit Counts:
pulp-admin docker repo update --repo-id gena --description='it is not docker repo but rpm repo'
Repository [gena] successfully updated
pulp-admin rpm repo list
--------------------------------------------------------------------
RPM Repositories
--------------------------------------------------------------------
Id: gena
Display Name: gena
Description: it is not docker repo but rpm repo
Content Unit Counts:
Since it's not possible to create repos of different types but with the same repo-id, I think it's OK to have a command line as
pulp-admin repo update --repo-id [repod_id]
Otherwise, maybe it's reasonable to include a test for a repo type.
+ This bug was cloned from Bugzilla Bug #1159075 +
Updated by bcourt about 9 years ago
We won't have a really good way to fix this without the repo-type being an official part of the repo model and understood as a core part of the CLI. Otherwise the only option would be to have every CLI plugin check the notes field (if they use it) and validate the repo-type note before updating.
Updated by bmbouter about 5 years ago
- Status changed from NEW to CLOSED - WONTFIX
Updated by bmbouter about 5 years ago
Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.
.