Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #5994

closed

Name clash with the SELinux policy for Pulp2

Added by evgeni over 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
bmbouter
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello, SELinux
Sprint:
Quarter:

Description

This repo is called pulp-selinux, but it really contains the policy for Pulp3 aka pulpcore, so I personally would have expected it to be called pulpcore-selinux.

Additionally, there is a pulp-selinux RPM package, built from the pulp2 source, so we'll have to rename this during packaging anyways as otherwise we end up with two packages with the same name.

Actions
Copy link
 #1

Updated by bmbouter over 4 years ago

  • Tags Katello-P2 added

Adding P2 label to identify the work priority w.r.t. Katello.

Actions
Copy link
 #2

Updated by fao89 over 4 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by bmbouter over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter

@evgeni I've renamed the pulp-selinux to pulpcore-selinux and notified pulp-dev here

Besides renaming the repository, was there more to do? Does the policy name conflict with pulp2 and we need to do something about that also?

Actions
Copy link
 #4

Updated by evgeni over 4 years ago

I would prefer if the files would also be called pulpcore.fc etc, not pulp.fc etc, but that's not strictly a requirement as the files in the old pulp2 policy are called pulp-COMPONENT.fc etc.

On January 21, 2020 6:54:05 PM UTC, Pulp <> wrote:

Actions
Copy link
 #5

Updated by evgeni over 4 years ago

But to your question, for consistency, I'd also rename the policy itself, yeah.

On January 21, 2020 6:54:05 PM UTC, Pulp <> wrote:

Added by bmbouter over 4 years ago

Revision 14144682 | View on GitHub

Renames policy from 'pulp' to 'pulpcore'

https://pulp.plan.io/issues/5994 re #5994

Actions
Copy link
 #6

Updated by bmbouter over 4 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #7

Updated by bmbouter over 4 years ago

@evgeni

The policy itself is now also renamed to pulpcore. What about the pulp_port label here: https://github.com/pulp/pulpcore-selinux/blob/master/pulp_port.te

Should that be pulpcore_port instead? I don't have an opinion.

Actions
Copy link
 #8

Updated by evgeni over 4 years ago

I guess it's more clear for the users if that's also called pulpcore_port.

On January 22, 2020 9:01:31 PM UTC, Pulp <> wrote:

Actions
Copy link
 #9

Updated by bmbouter over 4 years ago

Renaming pulp_port to pulpcore_port for clarity in last PR: https://github.com/pulp/pulpcore-selinux/pull/10

Added by bmbouter about 4 years ago

Revision c57e58b8 | View on GitHub

Rename pulp_port to pulpcore_port for clarity

Also add some uninstall docs.

https://pulp.plan.io/issues/5994 closes #5994

Actions
Copy link
 #10

Updated by bmbouter about 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #11

Updated by bmbouter about 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

The last PR got completed, so now all the names use pulpcore. I'm moving to CLOSED. Please let me know what else can be improved.

Actions
Copy link
 #12

Updated by ggainey almost 4 years ago

  • Tags Katello added
  • Tags deleted (Katello-P2)
Actions
Send by e-mail Copy link

Also available in: Atom PDF