Project

Profile

Help

Task #5932

closed

Pulp 3 Python client requires undocumented safe_chars_for_path_param configuration

Added by cottsay almost 3 years ago. Updated about 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 77
Quarter:

Description

When using the generated Python API client with Pulp 3, I was unable to reference any entities by the `pulp_href` because the client would URL-encode all of the slashes in the HREF when combining it with the base URL. This led to a `LocationParseException` coming out of `urllib3` every time.

Setting `safe_chars_for_path_param = '/'` in the client configuration worked around the issue, but since the client isn't usable without this magic configuration, it should be either set by default or clearly documented.

The pulp-openapi-generator[0] project should be updated to include `safe_chars_for_path_param = '/'` as the default setting.

[0] https://github.com/pulp/pulp-openapi-generator

Actions #1

Updated by daviddavis almost 3 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 63

Adding to sprint per triage.

Actions #2

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 63 to Sprint 64
Actions #3

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 64 to Sprint 65
Actions #4

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 65 to Sprint 66
Actions #5

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 66 to Sprint 67
Actions #6

Updated by rchan over 2 years ago

  • Sprint changed from Sprint 67 to Sprint 68
Actions #7

Updated by rchan over 2 years ago

  • Sprint deleted (Sprint 68)
Actions #8

Updated by dkliban@redhat.com over 2 years ago

  • Description updated (diff)
  • Category deleted (23)
Actions #9

Updated by dkliban@redhat.com over 2 years ago

  • Tracker changed from Issue to Task
  • % Done set to 0
  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #10

Updated by dkliban@redhat.com over 2 years ago

  • Tags deleted (Documentation)
Actions #11

Updated by rchan over 2 years ago

  • Sprint set to Sprint 74
Actions #12

Updated by rchan over 2 years ago

  • Sprint changed from Sprint 74 to Sprint 75
Actions #13

Updated by rchan over 2 years ago

  • Sprint changed from Sprint 75 to Sprint 76
Actions #14

Updated by rchan over 2 years ago

  • Sprint changed from Sprint 76 to Sprint 77
Actions #15

Updated by gerrod over 2 years ago

  • Assignee set to gerrod

Added by gerrod over 2 years ago

Revision b66a2f2f

Adds 'safe_char_for_path_param = '/'' to Python client defaults

fixes #5932 https://pulp.plan.io/issues/5932

Actions #16

Updated by gerrod over 2 years ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100
Actions #17

Updated by ttereshc about 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF