Project

Profile

Help

Actions
Send by e-mail Copy link

Task #5903

closed

Inconsistent naming convention for settings in plugin_template

Added by daviddavis over 4 years ago. Updated about 4 years ago.

Status:
CLOSED - COMPLETE
Priority:
Normal
Assignee:
daviddavis
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
CI/CD
Sprint:
Quarter:

Description

https://github.com/pulp/plugin_template/blob/master/README.md#generate-a-plugin-template-config-for-a-new-pulp-plugin

Some of the variables use underscores while others use hyphens. We should pick one.

Actions
Copy link
 #1

Updated by daviddavis over 4 years ago

  • Tags CI/CD added
Actions
Copy link
 #2

Updated by fao89 over 4 years ago

+1 to underscore

Actions
Copy link
 #3

Updated by mdepaulo@redhat.com over 4 years ago

It looks like the docs are wrong:

Every variable in plugin_template actually has underscores:
https://github.com/pulp/plugin_template/blob/master/plugin-template#L17
https://github.com/pulp/pulpcore/blob/master/template_config.yml

Added by daviddavis over 4 years ago

Revision 4deef572 | View on GitHub

Fix setting names using dashes

fixes #5903

Actions
Copy link
 #4

Updated by daviddavis over 4 years ago

  • Status changed from NEW to POST
  • Assignee set to daviddavis
Actions
Copy link
 #5

Updated by meldaresearch over 4 years ago

  • File 17a.jpg added
Actions
Copy link
 #6

Updated by daviddavis over 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #7

Updated by ttereshc about 4 years ago

  • File deleted (17a.jpg)
Actions
Copy link
 #8

Updated by daviddavis about 4 years ago

  • Tracker changed from Issue to Task
  • Status changed from MODIFIED to CLOSED - COMPLETE
  • % Done set to 0
Actions
Send by e-mail Copy link

Also available in: Atom PDF