Issue #577
closed
setting --serve-http at repo create only publishes repository to http and not https
Description
Description of problem:
If you set --serve-http to true at repo create, then the repo is only published over http and not https
Version-Release number of selected component (if applicable):
[root@cloud-qe-15 ~]# rpm -qa pulp-server
pulp-server-2.5.0-0.7.beta.el7.noarch
[root@cloud-qe-15 ~]#
How reproducible:
Steps to Reproduce:
1.create a repo with --serve-http
2.run repo sync
3.check in https & http ( See the files are only published under http)
Actual results:
[root@cloud-qe-15 ~]# pulp-admin rpm repo create --repo-id pulp --feed https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/pulp_unittest/ --serve-http true
Successfully created repository [pulp]
[root@cloud-qe-15 ~]#
[root@cloud-qe-15 ~]#
[root@cloud-qe-15 ~]#
[root@cloud-qe-15 ~]# pulp-admin rpm repo sync run --repo-id pulp
--------------------------------------------------------------------
Synchronizing Repository [pulp]
--------------------------------------------------------------------
This command may be exited via ctrl+c without affecting the request.
Downloading metadata...
[|]
... completed
Downloading repository content...
[==================================================] 100%
RPMs: 3/3 items
Delta RPMs: 0/0 items
... completed
Downloading distribution files...
[==================================================] 100%
Distributions: 3/3 items
... completed
Importing errata...
[\]
... completed
Importing package groups/categories...
[-]
... completed
Task Succeeded
Initializing repo metadata
[-]
... completed
Publishing Distribution files
[-]
... completed
Publishing RPMs
[==================================================] 100%
3 of 3 items
... completed
Publishing Delta RPMs
... skipped
Publishing Errata
[==================================================] 100%
52 of 52 items
... completed
Publishing Comps file
[==================================================] 100%
5 of 5 items
... completed
Publishing Metadata.
[-]
... completed
Closing repo metadata
[-]
... completed
Generating sqlite files
... skipped
Publishing files to web
[-]
... completed
Writing Listings File
[-]
... completed
Task Succeeded
[root@cloud-qe-15 ~]# ls l /var/lib/pulp/published/yum/https/repos/repos/pulp/pulp/demo_repos/. 1 apache apache 3 Oct 8 09:48 listing
total 4
-rw-r--r-
lrwxrwxrwx. 1 apache apache 68 Oct 8 09:48 zoo > /var/lib/pulp/published/yum/master/yum_distributor/zoo/1412776107.85. 1 apache apache 13 Oct 13 10:08 listing
[root@cloud-qe-15 ~]#
[root@cloud-qe-15 ~]#
[root@cloud-qe-15 ~]# ls -l /var/lib/pulp/published/yum/http/repos/repos/pulp/pulp/demo_repos/
total 4
-rw-r--r-
lrwxrwxrwx. 1 apache apache 69 Oct 13 10:08 pulp_unittest -> /var/lib/pulp/published/yum/master/yum_distributor/pulp/1413209296.27
[root@cloud-qe-15 ~]#
Expected results:
Additional info:
+ This bug was cloned from Bugzilla Bug #1152201 +
Updated by Anonymous over 8 years ago
Is --serve-https=true going to be deprecated?
+ This comment was cloned from Bugzilla #1152201 comment 1 +
Updated by bcourt over 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bcourt
--serve-https=true will not be deprecated. The CLI documentation states that it defaults to true. Therefor, if you want to disable serving via https during repo creation you will have to set --serve-https=false explicitly.
Added by bcourt over 8 years ago
Updated by bcourt over 8 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset e00819f4b7385c393ed92bc4359a3ac5123df8a9.
Updated by igulina@redhat.com about 8 years ago
- Status changed from 5 to 6
Reproduced on rpm -qa pulp-server
pulp-server-2.6.0-0.7.beta.el7.noarch
Verified on rpm -qa pulp-server
pulp-server-2.6.1-0.2.beta.el7.noarch
pulp-admin rpm repo create --repo-id pulp --feed https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/pulp_unittest/ --serve-http true
Successfully created repository [pulp]
pulp-admin rpm repo sync run --repo-id pulp
--------------------------------------------------------------------
Synchronizing Repository [pulp]
--------------------------------------------------------------------
This command may be exited via ctrl+c without affecting the request.
Downloading metadata...
[/]
... completed
Downloading repository content...
[==================================================] 100%
RPMs: 0/0 items
Delta RPMs: 0/0 items
... completed
Downloading distribution files...
[==================================================] 100%
Distributions: 3/3 items
... completed
Importing errata...
[\]
... completed
Importing package groups/categories...
[-]
... completed
Task Succeeded
Initializing repo metadata
[-]
... completed
Publishing Distribution files
[-]
... completed
Publishing RPMs
[==================================================] 100%
3 of 3 items
... completed
Publishing Delta RPMs
... skipped
Publishing Errata
[==================================================] 100%
52 of 52 items
... completed
Publishing Comps file
[==================================================] 100%
5 of 5 items
... completed
Publishing Metadata.
[-]
... completed
Closing repo metadata
[-]
... completed
Generating sqlite files
... skipped
Publishing files to web
[-]
... completed
Writing Listings File
[-]
... completed
Writing Listings File
[-]
... completed
Task Succeeded
ls -l /var/lib/pulp/published/yum/http/
total 0
drwxr-x---. 3 apache apache 32 Mar 27 07:32 repos
ls -l /var/lib/pulp/published/yum/https/
total 0
drwxr-x---. 3 apache apache 32 Mar 27 07:32 repos
ls -l /var/lib/pulp/published/yum/https/repos/repos/pulp/pulp/demo_repos/pulp_unittest/
images/ pulp-test-package-0.3.1-1.fc11.x86_64.rpm
Packages/ repodata/
pulp-dot-2.0-test-0.1.2-1.fc11.x86_64.rpm .treeinfo
pulp-test-package-0.2.1-1.fc11.x86_64.rpm
ls -l /var/lib/pulp/published/yum/http/repos/repos/pulp/pulp/demo_repos/pulp_unittest/
total 20
drwxr-x---. 2 apache apache 54 Mar 27 07:32 images
drwxr-x---. 2 apache apache 4096 Mar 27 07:32 Packages
lrwxrwxrwx. 1 apache apache 170 Mar 27 07:32 pulp-dot-2.0-test-0.1.2-1.fc11.x86_64.rpm > /var/lib/pulp/content/rpm/pulp-dot-2.0-test/0.1.2/1.fc11/x86_64/435d92e6c09248b501b8d2ae786f92ccfad69fab8b1bc774e2b66ff6c0d83979/pulp-dot-2.0-test-0.1.2-1.fc11.x86_64.rpm. 2 apache apache 4096 Mar 27 07:32 repodata
lrwxrwxrwx. 1 apache apache 170 Mar 27 07:32 pulp-test-package-0.2.1-1.fc11.x86_64.rpm -> /var/lib/pulp/content/rpm/pulp-test-package/0.2.1/1.fc11/x86_64/4dbde07b4a8eab57e42ed0c9203083f1d61e0b13935d1a569193ed8efc9ecfd7/pulp-test-package-0.2.1-1.fc11.x86_64.rpm
lrwxrwxrwx. 1 apache apache 170 Mar 27 07:32 pulp-test-package-0.3.1-1.fc11.x86_64.rpm -> /var/lib/pulp/content/rpm/pulp-test-package/0.3.1/1.fc11/x86_64/6bce3f26e1fc0fc52ac996f39c0d0e14fc26fb8077081d5b4dbfb6431b08aa9f/pulp-test-package-0.3.1-1.fc11.x86_64.rpm
drwxr-x--
Updated by dkliban@redhat.com about 8 years ago
- Status changed from 6 to CLOSED - CURRENTRELEASE
.
577 - Fix the the --serve-https observes defaults.
If the --serve-http flag is set to true the default value of --serve-https was improperly being set to false. This fixes it to maintain the default value even if the --serve-http flag is set.
closes #577