Issue #558
closed
Traceback is shown in admin.log if pulp-admin experiences an authentication failure
Description
Description of problem:
If pulp-admin is used without proper authentication, a traceback is logged on the .pulp/admin.log. Logging a failed authentication is perfectly reasonable, but logging a traceback is not. Remove the traceback and instead log a simple message about the failed authentication attempt, including the username attempted.
Version-Release number of selected component (if applicable):
rpm -qa | grep pulp-server
pulp-server-2.5.0-0.6.beta.fc20.noarch
How reproducible:
always
Steps to Reproduce:
pulp-admin login -u admin -p wrongpass
The specified user does not have permission to execute the given command
less .pulp/admin.log
2014-10-02 13:59:40,035 - ERROR - Client-side exception occurred
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/pulp/client/extensions/core.py", line 478, in run
exit_code = Cli.run(self, args)
File "/usr/lib/python2.7/site-packages/okaara/cli.py", line 974, in run
exit_code = command_or_section.execute(self.prompt, remaining_args)
File "/usr/lib/python2.7/site-packages/pulp/client/extensions/extensions.py", line 224, in execute
return self.method(*arg_list, **clean_kwargs)
File "/usr/lib/python2.7/site-packages/pulp/client/admin/admin_auth.py", line 58, in login
result = self.context.server.actions.login(username, password).response_body
File "/usr/lib/python2.7/site-packages/pulp/bindings/actions.py", line 32, in login
return self.server.POST (path)
File "/usr/lib/python2.7/site-packages/pulp/bindings/server.py", line 99, in POST
return self._request('POST', path, body=body, ensure_encoding=ensure_encoding)
File "/usr/lib/python2.7/site-packages/pulp/bindings/server.py", line 151, in _request
self._handle_exceptions(response_code, response_body)
File "/usr/lib/python2.7/site-packages/pulp/bindings/server.py", line 192, in _handle_exceptions
raise code_class_mappings[response_code](response_body)
PermissionsException: RequestException: POST request on /pulp/api/v2/actions/login/ failed with 401 - Authentication with username admin failed: invalid username or password
Expected results:
PermissionsException: RequestException: POST request on /pulp/api/v2/actions/login/ failed with 401 - Authentication with username admin failed: invalid username or password
+ This bug was cloned from Bugzilla Bug #1148915 +
.