Project

Profile

Help

Task #530

closed

Platform unit tests require qpidtoollibs to be installed

Added by rbarlow about 7 years ago. Updated about 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Sprint Candidate:
Tags:
Pulp 2
Sprint:
Quarter:

Description

Description of problem:
The platform unit tests will not pass if qpidtoollibs is not installed. This is unfriendly for community developers who wish to use rabbitmq. It would be better if the tests ran only if qpidtoollibs is installed.

Version-Release number of selected component (if applicable):
2.4.0-1

How reproducible:
Every time.

Steps to Reproduce:
1. Ensure that python-qpid-qmf is not installed.
2. Run the platform test suite.

Actual results:
======================================================================
ERROR: test_migrate (unit.server.db.migrations.test_migration_0009.TestMigration)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/mock.py", line 1216, in patched
arg = patching.__enter__()
File "/usr/lib/python2.6/site-packages/mock.py", line 1275, in enter
original, local = self.get_original()
File "/usr/lib/python2.6/site-packages/mock.py", line 1263, in get_original
"%s does not have the attribute %r" % (target, name)
AttributeError: <module 'pulp.server.db.migrations.0009_qpid_queues' from '/home/rbarlow/devel/pulp/server/pulp/server/db/migrations/0009_qpid_queues.py'> does not have the attribute 'BrokerAgent'

Expected results:
The Qpid specific tests should be skipped.

+ This bug was cloned from Bugzilla Bug #1142325 +

Actions #1

Updated by bmbouter about 7 years ago

The tests could also be written to not require any 3rd party libraries.

+ This comment was cloned from Bugzilla #1142325 comment 1 +

Actions #3

Updated by cduryee about 7 years ago

fixed in pulp 2.6.0-0.2.beta

+ This comment was cloned from Bugzilla #1142325 comment 3 +

Actions #4

Updated by igulina@redhat.com about 7 years ago

uname -r

3.17.1-302.fc21.x86_64

rpm -qa python-qpid-qmf

$

./run-tests.py

Running flake8
Running Unit Tests

.....
....

Ran 3236 tests in 214.981s

OK

+ This comment was cloned from Bugzilla #1142325 comment 4 +

Actions #5

Updated by dkliban@redhat.com over 6 years ago

  • Status changed from 6 to CLOSED - CURRENTRELEASE
Actions #7

Updated by bmbouter about 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF