Issue #5074
closed
bootstrap.sh --travis depends on black
Status:
CLOSED - WORKSFORME
Description
When updating the travis infrastructure via bootstrap.sh, it should verify (or ensure) that black is listed in test-requirements.txt
Is this strictly limited to black or do we also have this problem for other dependencies like coverage and flake8?
daviddavis wrote:
Is this strictly limited to black or do we also have this problem for other dependencies like coverage and flake8?
I have not checked, but looking at the mechanism, i sure think so.
- Triaged changed from No to Yes
- Sprint set to Sprint 55
- Tags Plugin Template added
I think this task is problematic. Take these scenarios for example:
- A plugin writer doesn't store their deps in test_requirements.txt but maybe uses a different file name
- A plugin writer is requiring a package like black indirectly. For example, they might be using flake8-black which requires black.
We provide a base set of packages when bootstrapping a plugin and I think that should suffice. It's pretty obvious when you're missing a dependency and it's easy to fix. I don't think we should check that the package is being required somehow when updating a plugin's files. It's not worth the effort.
@daviddavis, I agree w/ your reasoning here. Does the test-requirements.txt in the plugin_template have black in it, itself?
I see it in here so I think we're ok without the additional check.
- Sprint changed from Sprint 55 to Sprint 56
- Status changed from NEW to CLOSED - WORKSFORME
I'm setting this to WONTFIX but I am happy to discuss further if others disagree.
Also available in: Atom
PDF