https://pulp.plan.io/https://pulp.plan.io/favicon.ico2015-02-28T22:17:03ZPulpPulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10172015-02-28T22:17:03Zbmbouterbmbouter@redhat.com
<ul></ul><p>Thanks for reporting this. There are some changes around the queue workflow planned for a future major release that will remove the code causing the warning. Fixing that is the most effective way to resolve this bug.</p>
<p>The next planned minor release is 2.5.0, so I'm setting it to 2.5.0 and ON_QA. QA should verify that these warning now longer show with the new functionality.</p>
<p>As a note for our developers, the feature referred to above is called the "black friday sale" queueing model also known as the "pre-queue" model. This design change will cause the resource manager to dispatch the celery tasks itself, which stops the need to synchronously request a task while running an existing task, which is the situation that causes this warning.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c1" class="external">Bugzilla #1134502 comment 1</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10182015-02-28T22:17:05Zcduryeecduryee@redhat.com
<ul></ul><p>build: 2.5.0-0.6.beta</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c2" class="external">Bugzilla #1134502 comment 2</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10192015-02-28T22:17:05Zpthomas@redhat.com
<ul></ul><p>failing-qa<br>
still seeing these warnings</p>
<p>[root@cloud-qe-15 ~]# rpm -qa pulp-server<br>
pulp-server-2.5.0-0.7.beta.el7.noarch</p>
<p>Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: /usr/lib/python2.7/site-packages/celery/apps/worker.py:161: CDeprecationWarning:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: Starting from version 3.2 Celery will refuse to accept pickle by default.<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: The pickle serializer is a security concern as it may give attackers<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: the ability to execute any command. It's important to secure<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: your broker from unauthorized access when using pickle, so we think<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: that enabling pickle should require a deliberate action and not be<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: the default choice.<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: If you depend on pickle then you should set a setting to disable this<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: warning and to be sure that everything will continue working<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: when you upgrade to Celery 3.2::<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: CELERY_ACCEPT_CONTENT = ['pickle', 'json', 'msgpack', 'yaml']<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: You must only enable the serializers that you will actually use.<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING: warnings.warn(CDeprecationWarning(W_PICKLE_DEPRECATED))<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com pulp[28633]: py.warnings:WARNING:<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com celery[28633]: -------------- <a href="mailto:resource_manager@cloud-qe-15.idmqe.lab.eng.bos.redhat.com" class="email">resource_manager@cloud-qe-15.idmqe.lab.eng.bos.redhat.com</a> v3.1.11 (Cipater)<br>
Oct 09 10:54:43 cloud-qe-15.idmqe.lab.eng.bos.redhat.com celery[28633]: ---- <strong>**</strong> -----</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c3" class="external">Bugzilla #1134502 comment 3</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10202015-02-28T22:17:06Zrbarlow
<ul></ul><p>Hi Preethi,</p>
<p>The warning you noted is a different warning than this BZ is about. I think we can file that separately, but as for this BZ it should be OK to mark it VERIFIED. What do you think?</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c4" class="external">Bugzilla #1134502 comment 4</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10212015-02-28T22:17:07Zpthomas@redhat.com
<ul></ul><p>Sure that will work.</p>
<p>Moving to verified</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c5" class="external">Bugzilla #1134502 comment 5</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10222015-02-28T22:17:08Zbmbouterbmbouter@redhat.com
<ul></ul><p>Regarding the actual warning of interest "Never call result.get() within a task!", that was fixed along with this BZ [0] which was not fixed until 2.5.1. I'm moving the target release to 2.5.1 to align with the bugfix of the issue.</p>
<p>[0]: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1124570" class="external">https://bugzilla.redhat.com/show_bug.cgi?id=1124570</a></p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c6" class="external">Bugzilla #1134502 comment 6</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10232015-02-28T22:17:09Zcduryeecduryee@redhat.com
<ul></ul><p>fixed in pulp 2.6.0-0.2.beta</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c7" class="external">Bugzilla #1134502 comment 7</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=10242015-02-28T22:17:10Zpthomas@redhat.com
<ul></ul><p>verified<br>
[root@cloud-qe-4 ~]# rpm -qa pulp-server<br>
pulp-server-2.6.0-0.5.beta.el7.noarch<br>
[root@cloud-qe-4 ~]#<br>
No warnings</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1134502#c8" class="external">Bugzilla #1134502 comment 8</a> +</p> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=36142015-04-23T16:25:36Zrbarlow
<ul><li><strong>Status</strong> changed from <i>6</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=107132016-04-12T19:41:01Zbmbouterbmbouter@redhat.com
<ul><li><strong>Severity</strong> set to <i>1. Low</i></li></ul> Pulp - Issue #504: Fix result.get() call per celery deprecation warninghttps://pulp.plan.io/issues/504?journal_id=403392019-04-15T21:10:30Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>