Project

Profile

Help

Issue #4841

Deprecation warnings for Ansible installer

Added by amacdona@redhat.com over 1 year ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
Installer
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 53
Quarter:

Description

We have many uses of bare variables throughout the roles, resulting in this deprecation warning.

 [DEPRECATION WARNING]: evaluating pulp_install_db as a bare variable, this
behaviour will go away and you might need to add |bool to the expression in the
 future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature
will be removed in version 2.12. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.

AIUI, Ansible 2.12 will change the default value of CONDITIONAL_BARE_VARS to false. So we have 2 options:

1. Explicitly set CONDITIONAL_BARE_VARS to true
2. {{ moustache }} our variables (except in `when` statements?) or use `| bool` as suggested by the warning

Associated revisions

Revision 7aee1f4b View on GitHub
Added by amacdona@redhat.com over 1 year ago

Fix deprecated use of bare variable conditionals

Ansible 2.8 deprecates the use of bare variables being directly used as conditionals. https://github.com/ansible/ansible/blob/stable-2.8/changelogs/CHANGELOG-v2.8.rst

https://pulp.plan.io/issues/4841 fixes #4841

Revision 7aee1f4b View on GitHub
Added by amacdona@redhat.com over 1 year ago

Fix deprecated use of bare variable conditionals

Ansible 2.8 deprecates the use of bare variables being directly used as conditionals. https://github.com/ansible/ansible/blob/stable-2.8/changelogs/CHANGELOG-v2.8.rst

https://pulp.plan.io/issues/4841 fixes #4841

History

#1 Updated by amacdona@redhat.com over 1 year ago

  • Description updated (diff)

#2 Updated by amacdona@redhat.com over 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 53

#3 Updated by amacdona@redhat.com over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to amacdona@redhat.com

Note: This deprecation notice only exists on Ansible 2.8+ (this version is used by travis)

This issue is expected to be resolved in the pulp roles only. The geerlingguy postgres role still has some deprecated usage which will not be addressed by this work. (These deprecation warnings are limited and will only appear in one place in the log)

#4 Updated by amacdona@redhat.com over 1 year ago

  • Status changed from ASSIGNED to POST

#5 Updated by amacdona@redhat.com over 1 year ago

  • Status changed from POST to MODIFIED

#6 Updated by bmbouter 10 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#7 Updated by bmbouter 5 months ago

  • Category set to Installer
  • Tags deleted (Pulp 3 installer)

Please register to edit this issue

Also available in: Atom PDF