Issue #479
closedpulp-admin does not handle exception while accessing non-existent config file
Description
Description of problem:
Traceback is returned while accessing non-existent config file
Version-Release number of selected component (if applicable):
rpm -qa | grep pulp-admin
pulp-admin-client-2.4.0-0.29.beta.fc20.noarch
How reproducible:
always
Steps to Reproduce:
pulp-admin --config --help
Traceback (most recent call last):
File "/usr/bin/pulp-admin", line 9, in <module>
load_entry_point('pulp-client-admin==2.4.0', 'console_scripts', 'pulp-admin')()
File "/usr/lib/python2.7/site-packages/pulp/client/admin/__init__.py", line 35, in main
config_files, exception_handler_class=AdminExceptionHandler
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 66, in main
config = _load_configuration(config_filenames)
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 123, in _load_configuration
config = Config(*filenames)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 199, in init
self.open(input, filter)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 223, in open
fp = open(path)
IOError: [Errno 2] No such file or directory: '--help'
pulp-admin --config no_such_file
Traceback (most recent call last):
File "/usr/bin/pulp-admin", line 9, in <module>
load_entry_point('pulp-client-admin==2.4.0', 'console_scripts', 'pulp-admin')()
File "/usr/lib/python2.7/site-packages/pulp/client/admin/__init__.py", line 35, in main
config_files, exception_handler_class=AdminExceptionHandler
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 66, in main
config = _load_configuration(config_filenames)
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 123, in _load_configuration
config = Config(*filenames)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 199, in init
self.open(input, filter)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 223, in open
fp = open(path)
IOError: [Errno 2] No such file or directory: 'no_such_file'
pulp-admin --config=no_such_file
Traceback (most recent call last):
File "/usr/bin/pulp-admin", line 9, in <module>
load_entry_point('pulp-client-admin==2.4.0', 'console_scripts', 'pulp-admin')()
File "/usr/lib/python2.7/site-packages/pulp/client/admin/__init__.py", line 35, in main
config_files, exception_handler_class=AdminExceptionHandler
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 66, in main
config = _load_configuration(config_filenames)
File "/usr/lib/python2.7/site-packages/pulp/client/launcher.py", line 123, in _load_configuration
config = Config(*filenames)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 199, in init
self.open(input, filter)
File "/usr/lib/python2.7/site-packages/pulp/common/config.py", line 223, in open
fp = open(path)
IOError: [Errno 2] No such file or directory: 'no_such_file'
pulp-admin --config=no_such_file --help
Usage: pulp-admin [options]
Options:
-h, --help show this help message and exit
-u USERNAME, --username=USERNAME
credentials for the Pulp server; if specified will
bypass the stored certificate
-p PASSWORD, --password=PASSWORD
credentials for the Pulp server; must be specified
with --username
--debug enables debug logging
--config=CONFIG absolute path to the configuration file
--map prints a map of the CLI sections and commands
Expected results:
No such file or directory: 'no_such_file' + Error code [ `echo $?` -gt 0 ]
+ This bug was cloned from Bugzilla Bug #1125176 +