https://pulp.plan.io/https://pulp.plan.io/favicon.ico2015-02-28T22:09:58ZPulpPulp - Issue #448: gofer logs "secret"https://pulp.plan.io/issues/448?journal_id=8502015-02-28T22:09:58Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>Pulp passes the consumer DB object ID as the secret and is not used for authentication. Rather, it is used so that when a consumer is registered using the name of a previously unregistered consumer, the agent will not honor requests queued for the previous consumer. It leverages the gofer shared secret authentication mechanism as a matter of convenience only. So, logging the secret in this case represents no vulnerability to Pulp.</p>
<p>Long term gofer should mask out this filed when logging messages. Especially because 1.0+ logs to syslog which means that messages logged at DEBUG can now be viewed by non-root users.</p>
<p>To avoid confusion, Pulp /could/ pass the consumer DB object ID as part of the user defined data that is round-tripped on each request. The agent code could then explicitly add code to check the pass ID against the ID found in the consumer certificate and reject the request as needed. The downside is that we'd be writing code to avoid semantic confusion instead of using an existing mechanism. I think this would be a waste of time.</p>
<p>Pulp could also use the unique DB object ID when constructing the queue name (or gofer agent UUID). Like: pulp.agent.<_id>. This way, each registration would use a different queue and ignoring old requests would no longer be an issue. The pulp consumer certificate has this ID and it would be a straight forward change (though, would require another queue migration). A big problem with this approach is that candlepin certificates would not have this DB object ID so this would require additional changes to support this for SAT6. The need for agent queue reaping would be greater as this would potentially increase the rate at which we leak agent queues.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1105662#c1" class="external">Bugzilla #1105662 comment 1</a> +</p> Pulp - Issue #448: gofer logs "secret"https://pulp.plan.io/issues/448?journal_id=8512015-02-28T22:09:59Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>This should be cloned to the "gofer" product.</p>
<p>+ This comment was cloned from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1105662#c2" class="external">Bugzilla #1105662 comment 2</a> +</p> Pulp - Issue #448: gofer logs "secret"https://pulp.plan.io/issues/448?journal_id=362852019-04-12T18:11:32Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>CLOSED - WONTFIX</i></li></ul> Pulp - Issue #448: gofer logs "secret"https://pulp.plan.io/issues/448?journal_id=363612019-04-12T18:40:28Zbmbouterbmbouter@redhat.com
<ul><li><strong>Severity</strong> set to <i>1. Low</i></li></ul><p>Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" class="external">developer mailing list</a>.</p> Pulp - Issue #448: gofer logs "secret"https://pulp.plan.io/issues/448?journal_id=403952019-04-15T21:11:59Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>