Project

Profile

Help

Issue #4441

Our "Required PR" syntax is munged by Github and causes confusion

Added by daviddavis over 1 year ago. Updated 6 months ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Category:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:

Description

When you add a required pr to your commit message[0], Github will show "pulp/pulp_file#123" for "https://github.com/pulp/pulp_file/pull/123". This creates a lot of confusion as developers will sometimes do "Required PR: pulp/pulp_file#123".

Not sure about the best solution. One option would be to accept the syntax "Required PR: pulp/pulp_file#123" while another option would be to change the syntax.

[0] https://docs.pulpproject.org/en/3.0/nightly/contributing/continuous-integration.html#requiring-other-pull-requests

History

#1 Updated by CodeHeeler over 1 year ago

  • Triaged changed from No to Yes

#2 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

#3 Updated by Milesmsksth 6 months ago

Thank you so much for this. I was into this issue and tired to tinker around to check if its possible but couldnt get it done. Now that i have seen the way you did it, thanks guys with regards https://vidmate.onl/ https://messenger.red/

Please register to edit this issue

Also available in: Atom PDF