Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4420

closed

Random choices in the tests lead to variations in the coverage.

Added by mdellweg about 5 years ago. Updated over 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

In the functional tests, there are a lot of occurrences of `random.choice`. This leads inevitably to unpredictable test/coverage results.

Files

4420_IRC_Conversation.log (4.76 KB) 4420_IRC_Conversation.log Short conversation about the problem from IRC bherring, 02/18/2019 02:04 PM
Actions
Copy link
 #1

Updated by CodeHeeler about 5 years ago

  • Triaged changed from No to Yes
  • Tags Pulp 3 added
Actions
Copy link
 #2

Updated by mdellweg about 5 years ago

This is kind of hard to nail down, but PR 3876 [0] should really only add coverage. Yet it drops one line.

[0] https://github.com/pulp/pulp/pull/3876

Actions
Copy link
 #3

Updated by bherring about 5 years ago

Notes

Adding a reference [0] that would be useful to discuss, depending on the background.

Note that any time lines of code are removed without adding new functionality:

It is not wrong, your code contains less lines, so each line that is not tested is a larger percentage.
You can change the threshold for the amount of decrease to result in a failed build, on the projects page on coveralls.io.

There are also some suggestions in [0], depending on case.

Adding the IRC conversation for history about this conversation for those who missed it .

[0] - https://github.com/lemurheavy/coveralls-public/issues/565

Actions
Copy link
 #5

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #6

Updated by daviddavis over 3 years ago

  • Status changed from NEW to CLOSED - WONTFIX
Actions
Send by e-mail Copy link

Also available in: Atom PDF