Test #4344
closed
Move pulpcore tests to top-level directory in pulp/pulp
Description
I believe traditionally tests are not contained in the sourcetree with the the code itself. I think we would move the tests outside of the pulpcore folder itself so the 'tests' are at the top level.
This mirrors the cookiecutter layout for example where 'tests' are at the top level: https://github.com/audreyr/cookiecutter-pypackage
Updated by bmbouter over 4 years ago
Also for pulpcore-plugin as well: https://github.com/pulp/pulpcore-plugin/tree/master/pulpcore
Updated by bherring over 4 years ago
While this is initially written in/for Pulp and Pulpcore, I believe it would make sense to apply this same directory structure change to all current plug-ins and anything under github/pulp
The assumption is that any test or sub-testing folder structure would reside until the project's root test dir (e.g. functional, unit, etc.)
test
├── functional
│ ├── api
│ │ ├── __init__.py
│ │ └── test_functional.py
│ ├── __init__.py
│ ├── Makefile
│ └── utils.py
├── __init__.py
└── unit
├── __init__.py
└── test_unit.py
At this time, I believe that would include:
- pulp_docker
- pulp_ansible
- pulp_rpm
- pulp_file
- pulp_python
- pulp_ostree
The following are already structured as proposed:
- pulp_deb
- pulp-certguard
It may also be worth looking at updating the plugin_template to include an example or representative /test dir with a mock test already in place. This would encourage the test location/dir structure we would prefer.
Updated by daviddavis about 3 years ago
- Status changed from NEW to CLOSED - WONTFIX
.