Rename 'artifact' to '_artifact'
In light of the 4206 refactor  to change some Content fields to begin with a '_', of particular note the now '_artifacts' field, it would be clearer to update 'artifact' to '_artifact' to eliminate potential confusion.
#4 Updated by gmbnomis over 1 year ago
1. Avoiding attribute naming collisions when content writer's subclass Content.
2. Allow users to easily see which attributes are from pulpcore and therefore common to all content types.
Additionally, we decided in https://pulp.plan.io/issues/3678 to not include
artifact as a common pattern in Pulp core.
artifact is a convention right now. As it is not a convention enforced or suggested by the Pulp core API, I would leave it as it is.
That being said, I wouldn't mind
_artifact too much, either.
#9 Updated by dalley over 1 year ago
- Status changed from ASSIGNED to CLOSED - DUPLICATE
After discussing this with Brian, Jeff, and David, we decided to fix this more permanently in a different way, by moving the functionality into pulpcore.
I'm really sorry Pavel! I copied over some of your changes to my own PR. It sucks that the work ended up overlapping.
Please register to edit this issue