Task #4282
closed
Rename 'artifact' to '_artifact'
0%
Description
In light of the 4206 refactor [0] to change some Content fields to begin with a '_', of particular note the now '_artifacts' field, it would be clearer to update 'artifact' to '_artifact' to eliminate potential confusion.
Related issues
Updated by CodeHeeler over 5 years ago
- Tracker changed from Issue to Task
- % Done set to 0
Updated by dalley over 5 years ago
To some extent this is a discussion issue to determine if we should do this.
Updated by gmbnomis over 5 years ago
From: https://pulp.plan.io/issues/4206:
Motivations
1. Avoiding attribute naming collisions when content writer's subclass Content.2. Allow users to easily see which attributes are from pulpcore and therefore common to all content types.
Additionally, we decided in https://pulp.plan.io/issues/3678 to not include artifact as a common pattern in Pulp core.
Thus, artifact is a convention right now. As it is not a convention enforced or suggested by the Pulp core API, I would leave it as it is.
That being said, I wouldn't mind _artifact too much, either.
Updated by dkliban@redhat.com over 5 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
- Sprint set to Sprint 47
Updated by ppicka over 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ppicka
Updated by dalley about 5 years ago
- Status changed from ASSIGNED to CLOSED - DUPLICATE
After discussing this with Brian, Jeff, and David, we decided to fix this more permanently in a different way, by moving the functionality into pulpcore.
https://pulp.plan.io/issues/4366
I'm really sorry Pavel! I copied over some of your changes to my own PR. It sucks that the work ended up overlapping.
Updated by dalley about 5 years ago
- Has duplicate Story #4366: As a plugin writer, I have special purpose Content Serializers for content types that have 0, 1, or many artifacts per content added
Updated by bmbouter almost 5 years ago
- Tags deleted (
Pulp 3, Pulp 3 RC Blocker)
.