Project

Profile

Help

Task #4275

closed

Remove settings.py

Added by bmbouter about 6 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 47
Quarter:

Description

Pulp has two settings.py which duplicates the settings we need to maintain. This leads to out-of-date settings defaults where the commented value (the default is wrong). You can see the two here:

pulpcore/app/settings.py <--- the real settings file we should keep
pulpcore/etc/pulp/settings.py <----- the regularly out of date one with nothing but comments we should delete

It's valuable to clearly show defaults to users but this file isn't the best way.

Actions #1

Updated by amacdona@redhat.com about 6 years ago

  • Related to Story #3721: As a role user, server.yml behaviors are sane added
Actions #2

Updated by amacdona@redhat.com about 6 years ago

  • Related to deleted (Story #3721: As a role user, server.yml behaviors are sane)
Actions #3

Updated by amacdona@redhat.com about 6 years ago

I initially added a relationship to https://pulp.plan.io/issues/3721 but the ansible installer is actually templating the whole settings file at the moment, so this change should not actually change anything for the installer afaict.

Actions #4

Updated by amacdona@redhat.com about 6 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #5

Updated by CodeHeeler almost 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to CodeHeeler

Added by CodeHeeler almost 6 years ago

Revision 8f3629e7 | View on GitHub

Remove out of date settings.py

Fully commented out and regularly out of date, removed. True file located at pulpcore/app/settings.py

fixes #4275 https://pulp.plan.io/issues/4275

Added by CodeHeeler almost 6 years ago

Revision 8f3629e7 | View on GitHub

Remove out of date settings.py

Fully commented out and regularly out of date, removed. True file located at pulpcore/app/settings.py

fixes #4275 https://pulp.plan.io/issues/4275

Actions #7

Updated by rchan almost 6 years ago

  • Sprint set to Sprint 47
Actions #8

Updated by dalley almost 6 years ago

  • Status changed from ASSIGNED to POST
Actions #9

Updated by CodeHeeler almost 6 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #10

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #11

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)
Actions #12

Updated by bmbouter about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF