Project

Profile

Help

Task #4275

Remove settings.py

Added by bmbouter 10 months ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 47

Description

Pulp has two settings.py which duplicates the settings we need to maintain. This leads to out-of-date settings defaults where the commented value (the default is wrong). You can see the two here:

pulpcore/app/settings.py <--- the real settings file we should keep
pulpcore/etc/pulp/settings.py <----- the regularly out of date one with nothing but comments we should delete

It's valuable to clearly show defaults to users but this file isn't the best way.

Associated revisions

Revision 8f3629e7 View on GitHub
Added by CodeHeeler 10 months ago

Remove out of date settings.py

Fully commented out and regularly out of date, removed.
True file located at pulpcore/app/settings.py

fixes #4275
https://pulp.plan.io/issues/4275

Revision 8f3629e7 View on GitHub
Added by CodeHeeler 10 months ago

Remove out of date settings.py

Fully commented out and regularly out of date, removed.
True file located at pulpcore/app/settings.py

fixes #4275
https://pulp.plan.io/issues/4275

History

#1 Updated by amacdona@redhat.com 10 months ago

  • Related to Story #3721: As a role user, server.yml behaviors are sane added

#2 Updated by amacdona@redhat.com 10 months ago

  • Related to deleted (Story #3721: As a role user, server.yml behaviors are sane)

#3 Updated by amacdona@redhat.com 10 months ago

I initially added a relationship to https://pulp.plan.io/issues/3721 but the ansible installer is actually templating the whole settings file at the moment, so this change should not actually change anything for the installer afaict.

#4 Updated by amacdona@redhat.com 10 months ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

#5 Updated by CodeHeeler 10 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to CodeHeeler

#7 Updated by rchan 10 months ago

  • Sprint set to Sprint 47

#8 Updated by dalley 10 months ago

  • Status changed from ASSIGNED to POST

#9 Updated by CodeHeeler 10 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#10 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#11 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)

Please register to edit this issue

Also available in: Atom PDF