Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4187

closed

Pulp3's systemd unit names should not conflict with Pulp2's systemd unit names

Added by bmbouter about 6 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
ipanova@redhat.com
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 49
Quarter:

Description

Problem

Pulp2 uses the following systemd unit names: 'pulp_resource_manager', 'pulp_workers' among others.
Pulp3 also needs those same components and uses 'pulp_resource_manager' and 'pulp_workers' also. per the docs

Solution: Have Pulp3 change

Pulp would switch to 'pulp3_resource_manager' and 'pulp3_worker@1', pulp3_worker@2.

Solution: Have Pulp2 change

Pulp would switch to 'pulp2_resource_manager' and 'pulp2_workers'.

Solution: Leave them conflicting and the user avoids through configuration

This option would have a documentation note that if these systemd names conflict with your system, perhaps due to a Pulp2 install already there, that you can rename the unit names and that is OK.

Also we would need to add a variable for this to the Ansible installer so automated installs could also do the same thing.

Actions
Copy link
 #1

Updated by CodeHeeler about 6 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #2

Updated by bmbouter almost 6 years ago

  • Tags Pulp 3 RC Blocker, Pulp 3 installer added

I think this should be an RC blocker since it was identified as preventing Pulp2 and Pulp3 from running on the same system. Changing it would also be backwards incompatible.

Actions
Copy link
 #3

Updated by amacdona@redhat.com almost 6 years ago

IMO we should do both Option 1 and Option 3.

The default should not conflict with Pulp2, but users should also be able configure it. Completing Option 1 should be an RC blocker, but completing Option 3 should be added as a separate story and does not need to be an RC blocker, and will be backwards compatible.

Actions
Copy link
 #4

Updated by daviddavis almost 6 years ago

+1 to asmacdo's proposal.

Actions
Copy link
 #5

Updated by bmbouter almost 6 years ago

Actions
Copy link
 #6

Updated by ipanova@redhat.com almost 6 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions
Copy link
 #7

Updated by jortel@redhat.com almost 6 years ago

Using hyphens for names in Linux is far more conventional and convenient that underscores. Let's resolve the conflict and improve the naming all at once by naming the pulp3 services: pulp-resource-manager and pulp-worker@1 and not rename pulp2 services.

Actions
Copy link
 #8

Updated by daviddavis almost 6 years ago

It seems like other systemd units use hyphens as well. The only downside is there's nothing to indicate for users whether pulp-resource-manager or pulp_resource_manager is pulp 2 or 3.

Regardless, I think I am +1 to using hyphens.

Actions
Copy link
 #9

Updated by ttereshc almost 6 years ago

  • Sprint set to Sprint 49
Actions
Copy link
 #10

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com
Actions
Copy link
 #11

Updated by bmbouter almost 6 years ago

+1 to hyphens for Pulp3

Actions
Copy link
 #12

Updated by ipanova@redhat.com almost 6 years ago

issue for option3 created https://pulp.plan.io/issues/4429

Added by ipanova@redhat.com almost 6 years ago

Revision 6038d55a | View on GitHub

Use hyphens for Pulp3' system units name.

closes #4187 https://pulp.plan.io/issues/4187

Actions
Copy link
 #14

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from POST to ASSIGNED

Added by ipanova@redhat.com almost 6 years ago

Revision bfa27591 | View on GitHub

Use hyphens for Pulp3' system units name.

closes #4187 https://pulp.plan.io/issues/4187

Actions
Copy link
 #15

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from ASSIGNED to POST

Added by ipanova@redhat.com almost 6 years ago

Revision bed44546 | View on GitHub

Use hyphens for Pulp3' system units name.

closes #4187 https://pulp.plan.io/issues/4187

Added by ipanova@redhat.com almost 6 years ago

Revision bed44546 | View on GitHub

Use hyphens for Pulp3' system units name.

closes #4187 https://pulp.plan.io/issues/4187

Added by ipanova@redhat.com almost 6 years ago

Revision 9394e92b | View on GitHub

Use hyphens for Pulp3' system units name. closes #4187 https://pulp.plan.io/issues/4187

Added by ipanova@redhat.com almost 6 years ago

Revision 9394e92b | View on GitHub

Use hyphens for Pulp3' system units name. closes #4187 https://pulp.plan.io/issues/4187

Actions
Copy link
 #16

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #18

Updated by ipanova@redhat.com almost 6 years ago

Applied in changeset commit:pulpcore-plugin|aafb6f9fb5ac7efe253eba4b103a5c542c78feea.

Actions
Copy link
 #22

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from MODIFIED to ASSIGNED
Actions
Copy link
 #23

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from ASSIGNED to POST

Added by bmbouter almost 6 years ago

Revision 4a9b071f | View on GitHub

Update to latest ansible-pulp3

This is primarily to pick up the systemd name changes that came with this change https://github.com/pulp/ansible-pulp3/pull/75/files

https://pulp.plan.io/issues/4187 re #4187

Actions
Copy link
 #24

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #25

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from MODIFIED to POST
Actions
Copy link
 #26

Updated by ipanova@redhat.com almost 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #28

Updated by ipanova@redhat.com almost 6 years ago

Applied in changeset plugin_template:commit:bfa275912708357be33b66047544cebd30cd982d.

Actions
Copy link
 #32

Updated by daviddavis over 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #33

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 RC Blocker)
Actions
Copy link
 #34

Updated by bmbouter about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Copy link
 #35

Updated by bmbouter over 4 years ago

  • Category set to Installer - Moved to GitHub issues
  • Tags deleted (Pulp 3 installer)
Actions
Send by e-mail Copy link

Also available in: Atom PDF