Project

Profile

Help

Issue #414

closed

refactor upload command usage

Added by mhrivnak about 9 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.4 Beta
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The upload command has been slightly reworked, so it will create a default "upload manager" for itself. This was because each set of extensions had exactly the same 7 lines of code to create a boiler-plate manager. It had clearly been copy-pasted.

This work should
- remove calls to the command's "initialize()" method, which no longer has any effect
- remove the boiler-plate "_upload_manager()" functions in the extensions that create an upload manager, letting the base class do it for you

Example that should be removed: https://github.com/pulp/pulp_rpm/blob/4a2403a5d840f36fd78d5c9a2d482c813523227a/extensions_admin/pulp_rpm/extensions/admin/rpm_repo/pulp_cli.py#L115

+ This bug was cloned from Bugzilla Bug #1086281 +

Also available in: Atom PDF