Project

Profile

Help

Issue #414

refactor upload command usage

Added by mhrivnak almost 7 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.4 Beta
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The upload command has been slightly reworked, so it will create a default "upload manager" for itself. This was because each set of extensions had exactly the same 7 lines of code to create a boiler-plate manager. It had clearly been copy-pasted.

This work should
- remove calls to the command's "initialize()" method, which no longer has any effect
- remove the boiler-plate "_upload_manager()" functions in the extensions that create an upload manager, letting the base class do it for you

Example that should be removed: https://github.com/pulp/pulp_rpm/blob/4a2403a5d840f36fd78d5c9a2d482c813523227a/extensions_admin/pulp_rpm/extensions/admin/rpm_repo/pulp_cli.py#L115

+ This bug was cloned from Bugzilla Bug #1086281 +

History

#1 Updated by bmbouter over 6 years ago

  • Severity changed from Low to 1. Low

#2 Updated by bmbouter over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

#3 Updated by bmbouter over 2 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#4 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF