https://pulp.plan.io/https://pulp.plan.io/favicon.ico2018-04-16T14:27:05ZPulpPulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=275102018-04-16T14:27:05Zbmbouterbmbouter@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27510/diff?detail_id=28119">diff</a>)</li></ul> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=275182018-04-16T16:14:55Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>This has potential.</p>
<p>This seems like a higher level abstraction that is different than the <em>ChangeSet</em>. Perhaps something named <em>PendingVersion</em> since the plugin writer is really (declaratively) defining the set of content to be included in the new repository version rather than a set of changes to be applied. The <em>PendingVersion</em> could/should use the <em>ChangeSet</em> internally. I should consider leaving the <em>ChangeSet</em> as-is (potentially minus the SizedIterator) in the PluginAPI as well in support of our layered API approach.</p>
<p>The <em>SizedIterator</em> is only needed to report progress. Without this information, I don't see how progress can be reported (by anything) without constantly adjusting the TOTAL reported. Are you proposing this and will it be acceptable?</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=276892018-04-19T18:28:30Zbmbouterbmbouter@redhat.com
<ul><li><strong>Subject</strong> changed from <i>As a plugin writer, I have declarative Changesets</i> to <i>As a plugin writer, I have declarative PendingVersion</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27689/diff?detail_id=28308">diff</a>)</li></ul><p>After @jortel and I talked we thought it would be good to add a new object on top which does the differencing and drives the changeset additions and removals. This pairs with the work in <a href="https://pulp.plan.io/issues/3582#note-1" class="external">https://pulp.plan.io/issues/3582#note-1</a></p>
<p>This new object would be the go-to interface for plugin writers and would also create the repo version as well as mark it as completed.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=276902018-04-19T18:36:22Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>The changes in the description look good!</p>
<p>Suggestions:</p>
<p>This is a change from before where plugin writer's would only yield PendingContent objects to Changesets<br>
- if they believed they needed to be downloaded.<br>
+ if they want the content to be added to the repository.</p>
<p>This is a declarative interface because every time the PendingVersion runs the plugin code<br>
- "declares" the remote repository state.<br>
+ "declares" the content to be contained in a new repository version.</p>
<p>I think PendingVersion.create() would be more appropriate than apply().</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=276912018-04-19T18:43:45Zbmbouterbmbouter@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27691/diff?detail_id=28309">diff</a>)</li></ul><p>Those are good changes. Thanks @jortel. I incorporated them into the ticket also.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=276922018-04-19T18:48:19Zbmbouterbmbouter@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27692/diff?detail_id=28310">diff</a>)</li></ul> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=278192018-04-24T18:12:56Zgmbnomis
<ul></ul><p>I am not sure that I understand:</p>
<p><cite>2. Changesets require plugin writers to download metadata to compute additions and removals, which puts metadata downloading outside of the Changeset's stream processing.</cite></p>
<p>In the example, the metadata is fetched before entering the generator part. Or does "fetch metadata" mean that this can be an iterator that dynamically gets metadata? (which is probably tricky to get right)</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=279032018-04-30T14:10:51Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li></ul><p>I'm building a prototype on top of Jortel's changes <a href="https://github.com/pulp/pulp/pull/3464/" class="external">https://github.com/pulp/pulp/pull/3464/</a> I'll post a link to it when it's available.</p>
<p><a class="user active" href="https://pulp.plan.io/users/310">gmbnomis</a>, yes, "fetch metadata" means that an iterator the plugin writer provides would be fetching the metadata as part of the stream. In the example that is <code>_pending_content()</code>.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=279042018-04-30T14:17:00Zbmbouterbmbouter@redhat.com
<ul><li><strong>Assignee</strong> set to <i>bmbouter</i></li></ul><p>Assigning so others know someone is working on a prototype.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=297142018-07-25T20:50:07Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>NEW</i></li><li><strong>Assignee</strong> deleted (<del><i>bmbouter</i></del>)</li></ul><p>I'm no longer actively working on this issue.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=302402018-08-21T20:20:38Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>CLOSED - WONTFIX</i></li></ul><p>With DeclarativeVersion available, I don't plan to pursue this work. I'm closing as WONTFIX along with the associated PR.</p> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=414102019-04-25T16:45:26Zdaviddavis
<ul><li><strong>Sprint/Milestone</strong> set to <i>3.0.0</i></li></ul> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=425532019-04-26T20:35:47Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>Pulp 3</i></del>)</li></ul> Pulp - Story #3570: As a plugin writer, I have declarative PendingVersionhttps://pulp.plan.io/issues/3570?journal_id=583982020-06-16T20:59:51Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Performance</i> added</li><li><strong>Tags</strong> deleted (<del><i>Sync Performance</i></del>)</li></ul>