https://pulp.plan.io/https://pulp.plan.io/favicon.ico2018-04-06T20:07:27ZPulpPulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=273212018-04-06T20:07:27Zdaviddavis
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27321/diff?detail_id=27931">diff</a>)</li><li><strong>Tags</strong> <i>Documentation</i> added</li></ul> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=273562018-04-10T14:47:46Zamacdona@redhat.comaustin@redhat.com
<ul><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul><p>Since "version" is not really a field, we should not include that. "number" works, but may be unnecessary. I think we should use max and min (+1)</p>
<p>versions/?min=1, max=4</p>
<p>That looks pretty clear to me. If we do gte/lte, it requires us to name the field. (+0)</p>
<p>versions/?number__gte=1,number__lte=4</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=273782018-04-11T00:27:54Zdalleydalley@redhat.com
<ul></ul><p>I would actually prefer to rename the field for reasons laid out here:</p>
<p><a href="https://pulp.plan.io/issues/3557#note-2" class="external">https://pulp.plan.io/issues/3557#note-2</a></p>
<p>I'm not entirely comfortable with "max" and "min" because there are enough fields on a RepositoryVersion that it isn't immediately clear which one they would correspond to. And "number" doesn't even have any help text at the moment.</p>
<p>I'm also not against it, it is nice and short (+0 I guess), I would just favor consistency over minor convenience.</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274122018-04-11T16:14:28Zamacdona@redhat.comaustin@redhat.com
<ul></ul><p>I like the user experience of renaming "number" to "version" for this filter, but it just seems weird elsewhere.</p>
<p>To me, "RepositoryVersion.version" is awkward "RepositoryVersion.number" makes sense. Rename to "version" -0</p>
<p>I'm convinced that we can use "*__gte" for the field. As it is, "number__gte" seems fine. +1</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274152018-04-11T16:51:10Zdalleydalley@redhat.com
<ul></ul><p>To clarify - I did mean "filter param" instead of field. I'm +1 on just having "number__gte" and "number__lte" instead of version_min and version_max.</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274172018-04-11T16:58:58Zdalleydalley@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/27417/diff?detail_id=28018">diff</a>)</li></ul> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274272018-04-12T00:08:16Zdalleydalley@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>dalley</i></li></ul> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274322018-04-12T13:27:40Zdalleydalley@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li><li><strong>Sprint</strong> set to <i>Sprint 35</i></li></ul><p>PR: <a href="https://github.com/pulp/pulp/pull/3428" class="external">https://github.com/pulp/pulp/pull/3428</a></p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274372018-04-12T15:10:14Zbmbouterbmbouter@redhat.com
<ul></ul><p>+1 on this resolution.</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=274492018-04-12T20:25:49Zdalleydalley@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Fix confusing inconsistencies with RepositoryVersion filters closes #3558 https://pulp.plan.io/i..." href="https://pulp.plan.io/projects/pulp/repository/pulp/revisions/56a553a30789aa6e0c6310995d6bcb42b5ca0eb7">pulp|56a553a30789aa6e0c6310995d6bcb42b5ca0eb7</a>.</p> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=276662018-04-19T15:12:51Zdkliban@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>3.0.0</i></li></ul> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=425602019-04-26T20:35:50Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>Pulp 3, Pulp 3 MVP</i></del>)</li></ul> Pulp - Issue #3558: Repository version filters are confusinghttps://pulp.plan.io/issues/3558?journal_id=510672019-12-13T17:30:06Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul>