Project

Profile

Help

Task #3553

Move tests out of Pulp's application code

Added by bmbouter over 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 35

Description

The tests currently live at: https://github.com/pulp/pulp/tree/3.0-dev/pulpcore/pulpcore/app/tests

This is atypical. Usually tests live outside of the application code itself as a peer of it.

Since we do have two packages living in one repository, the existing tests would move from /pulpcore/pulpcore/app/tests to /pulpcore/tests/. Eventually we would add plugin API tests in /plugin/tests/

Associated revisions

Revision f22615c1 View on GitHub
Added by dalley over 1 year ago

Move tests out of pulpcore/app

closes: #3553
https://pulp.plan.io/issues/3553

Revision f22615c1 View on GitHub
Added by dalley over 1 year ago

Move tests out of pulpcore/app

closes: #3553
https://pulp.plan.io/issues/3553

Revision f22615c1 View on GitHub
Added by dalley over 1 year ago

Move tests out of pulpcore/app

closes: #3553
https://pulp.plan.io/issues/3553

History

#1 Updated by bmbouter over 1 year ago

  • Description updated (diff)

#2 Updated by daviddavis over 1 year ago

  • Groomed changed from No to Yes
  • Sprint set to Sprint 35

#3 Updated by dalley over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley

#4 Updated by dalley over 1 year ago

  • Status changed from ASSIGNED to POST

#5 Updated by dalley over 1 year ago

This exact scheme doesn't work because the tests/pulpcore package mirrors the pulpcore package and attempts to import the code from tests/pulpcore, which fails.

What we really want is just to move the tests from pulpcore/app/tests to pulpcore/tests. That is the proper structure since both pulpcore and pulpcore-plugin are their own separate python packages.

#6 Updated by bmbouter over 1 year ago

@dalley, Yes that sounds right. Would you want to update the ticket description for posterity?

#7 Updated by dalley over 1 year ago

@bmbouter sure

#8 Updated by dalley over 1 year ago

  • Description updated (diff)

#9 Updated by dalley over 1 year ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#10 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#11 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF