Project

Profile

Help

Task #3553

closed

Move tests out of Pulp's application code

Added by bmbouter about 6 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 35
Quarter:

Description

The tests currently live at: https://github.com/pulp/pulp/tree/3.0-dev/pulpcore/pulpcore/app/tests

This is atypical. Usually tests live outside of the application code itself as a peer of it.

Since we do have two packages living in one repository, the existing tests would move from /pulpcore/pulpcore/app/tests to /pulpcore/tests/. Eventually we would add plugin API tests in /plugin/tests/

Actions #1

Updated by bmbouter about 6 years ago

  • Description updated (diff)
Actions #2

Updated by daviddavis about 6 years ago

  • Groomed changed from No to Yes
  • Sprint set to Sprint 35
Actions #3

Updated by dalley about 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
Actions #4

Updated by dalley about 6 years ago

  • Status changed from ASSIGNED to POST
Actions #5

Updated by dalley about 6 years ago

This exact scheme doesn't work because the tests/pulpcore package mirrors the pulpcore package and attempts to import the code from tests/pulpcore, which fails.

What we really want is just to move the tests from pulpcore/app/tests to pulpcore/tests. That is the proper structure since both pulpcore and pulpcore-plugin are their own separate python packages.

Added by dalley about 6 years ago

Revision f22615c1 | View on GitHub

Move tests out of pulpcore/app

closes: #3553 https://pulp.plan.io/issues/3553

Added by dalley about 6 years ago

Revision f22615c1 | View on GitHub

Move tests out of pulpcore/app

closes: #3553 https://pulp.plan.io/issues/3553

Actions #6

Updated by bmbouter about 6 years ago

dalley, Yes that sounds right. Would you want to update the ticket description for posterity?

Actions #7

Updated by dalley about 6 years ago

Actions #8

Updated by dalley about 6 years ago

  • Description updated (diff)
Actions #9

Updated by dalley about 6 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #10

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #11

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #12

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF