Project

Profile

Help

Task #3379

closed

Enable required checks on Github for core and pulp_file

Added by bmbouter almost 5 years ago. Updated over 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Make the following checks required:

  • PR review
  • docs builders check
  • Travis CI passing
  • "default" which is the Jenkins test runner check

For the following repos and branches:

  • 'pulp' repo 'master' branch
  • 'pulp' repo '3.0-dev' branch
  • 'pulp_file' repo 'master' branch

In terms of a disable/reenable process:

From the github docs it looks like an 'Administrator' of a repository can enable/disable the required checks. Currently the following people have that permissions: @ipanova, rchan, @jortel, ttereshc, and bmbouter

To temporarily disable:

1. Contact one of ^ admins via pulp-dev and irc that a check is failing permanently
2. Discuss what the issue is and make a decision to disable the checks or not.
3. If disabling, disable via github and make and issue to re-enable
4. notify pulp-dev with an update of the changes and the issue link
5. work to re-enable checks as soon as possible

We should put ^ and an overall update of the latest required checks into the pulp2 and pulp3 docs. We can put those into these locations:

pulp2: https://docs.pulpproject.org/dev-guide/contributing/merging.html#pull-requests
pulp3: https://docs.pulpproject.org/dev-guide/contributing/merging.html#pull-requests

Actions #1

Updated by bmbouter almost 5 years ago

  • Description updated (diff)

rewriting to include the 'default' check and providing some better organizing.

Actions #2

Updated by rchan almost 5 years ago

I don't see any mention of the "ability to temporarily disable them" mentioned in the pulp-dev discussion, will this be handled via a different process (can we specify) or just inadvertently left out?

Actions #3

Updated by bmbouter over 4 years ago

That is an oversight on my part from haste. We talked about that on the mailing list and I need to add it here. I'll update this ticket with a plan for comment.

Actions #5

Updated by bmbouter over 4 years ago

  • Description updated (diff)

Adding info about the temporary disabling process

Actions #6

Updated by bmbouter over 4 years ago

  • Sprint Candidate changed from No to Yes

marking as a sprint candidate in hopes that it gets groomed

Actions #7

Updated by bmbouter over 4 years ago

  • Subject changed from Enable strict checks on Github for core and pulp_file to Enable required checks on Github for core and pulp_file
Actions #8

Updated by daviddavis over 4 years ago

  • Groomed changed from No to Yes
Actions #9

Updated by daviddavis over 4 years ago

  • Sprint Candidate deleted (Yes)
Actions #10

Updated by bmbouter over 4 years ago

  • Status changed from NEW to CLOSED - WONTFIX
  • Sprint Candidate set to No

With the recent enabling of continuous integration at merge time this ticket is "aged out". The current state of Pulp continuous integration work is described here: https://pulp.plan.io/projects/pulp/wiki/Continuous_Delivery_of_Pulp_3/

With CI as an already enabled required check as part of a totally separate effort, it happened to address the original need for Pulp3. I suggest leaving Pulp2 alone in this area and just closing this ticket.

Please reopen if anyone feels differently.

Actions #11

Updated by bmbouter over 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF