https://pulp.plan.io/https://pulp.plan.io/favicon.ico2018-01-24T12:52:19ZPulpPulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=242092018-01-24T12:52:19Zgmbnomis
<ul></ul><p>PR with fix is here: <a href="https://github.com/pulp/pulp/pull/3282" class="external">https://github.com/pulp/pulp/pull/3282</a><br>
PR for pulp-smash is here: <a href="https://github.com/PulpQE/pulp-smash/pull/849" class="external">https://github.com/PulpQE/pulp-smash/pull/849</a></p>
<p>I am not sure about which branches to target and what markup is needed to properly link the PRs to this issue. Let me know if I need to change the PRs.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=242452018-01-26T15:41:22Zdalleydalley@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>POST</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=242462018-01-26T15:42:27Zdalleydalley@redhat.com
<ul><li><strong>Assignee</strong> set to <i>gmbnomis</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=242942018-01-30T13:13:44ZAnonymous
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Actually use rsync_extra_args for all rsync calls Commit c981b94de498 ("As user I want to be abl..." href="https://pulp.plan.io/projects/pulp/repository/pulp/revisions/b7705381ce0fd370fe24037910df44ad9d12f310">pulp|b7705381ce0fd370fe24037910df44ad9d12f310</a>.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243642018-01-31T22:15:51Zkersom
<ul></ul><p>Pulp-Smash test related to this issue failed.</p>
<p>[[https://git.io/vN5Ni]]</p>
<p>When publishing the --dry-run the following structure is present on the host.</p>
<pre><code>[root@r7-p215n a0b5ab57-500]# tree
.
├── content
│ └── units
└── f430b0da-8d36-4b54-84f5-7def03e37b82
└── repodata
</code></pre>
<p>Then the set returned is not empty.</p>
<p>Please, clarify expected behaviour.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243652018-01-31T22:16:23Zkersom
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>ASSIGNED</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243662018-01-31T23:50:58Zgmbnomis
<ul></ul><p>Strange. This is the behavior I expect to see before the bug fix (directories are created as the --dry-run flag is not used in remote_mkdir(). No files/links get created since --dry-run is used in the remaining rsync calls).</p>
<p>I can't reproduce the failure. For me, the test runs using the following setup:</p>
<ul>
<li>Use current master of pulp, pulp_rpm and pulp-smash</li>
<li>Comment out the skiptest in the <code>RsyncExtraArgsTestCase</code>
</li>
<li>Run the test in a pulp-devel environment (docker). I get:</li>
</ul>
<pre><code> python -m unittest -v pulp_smash.tests.pulp2.rpm.api_v2.test_rsync_distributor.RsyncExtraArgsTestCase
/home/vagrant/.virtualenvs/pulp-smash/lib/python3.5/site-packages/urllib3/connectionpool.py:858: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
test_all (pulp_smash.tests.pulp2.rpm.api_v2.test_rsync_distributor.RsyncExtraArgsTestCase)
Use the ``rsync_extra_args`` RPM rsync distributor option. ... ok
----------------------------------------------------------------------
Ran 1 test in 38.948s
OK
</code></pre>
<p>Could you elaborate on your test setup?</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243772018-02-01T15:55:08Zkersom
<ul></ul><p>I am using nightly builds of Pulp. I just installed Pulp again, and tested against the following setup.</p>
<pre><code class="text syntaxhl" data-language="text">FAIL: test_all (pulp_smash.tests.pulp2.rpm.api_v2.test_rsync_distributor.RsyncExtraArgsTestCase)
Use the ``rsync_extra_args`` RPM rsync distributor option.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/kersom/00_Code/01_Git/pulp-smash/pulp_smash/tests/pulp2/rpm/api_v2/test_rsync_distributor.py", line 821, in test_all
self.assertSetEqual(files, set())
AssertionError: Items in the first set but not the second:
'content'
'9d1c794c-897f-44d0-a3d5-147ce0f4fafc'
----------------------------------------------------------------------
Ran 1 test in 40.420s
FAILED (failures=1)
</code></pre>
<pre><code class="text syntaxhl" data-language="text">[root@r74-p215n ~]# rpm -qa | sort | grep -i pulp
pulp-admin-client-2.15.1-1.git.6.55208a3.el7.noarch
pulp-deb-admin-extensions-1.6.0-1.el7.noarch
pulp-deb-plugins-1.6.0-1.el7.noarch
pulp-docker-admin-extensions-3.1.1-1.git.3.55208a3.el7.noarch
pulp-docker-plugins-3.1.1-1.git.3.55208a3.el7.noarch
pulp-ostree-admin-extensions-1.3.0-1.el7.noarch
pulp-ostree-plugins-1.3.0-1.el7.noarch
pulp-puppet-admin-extensions-2.15.1-1.git.4.55208a3.el7.noarch
pulp-puppet-plugins-2.15.1-1.git.4.55208a3.el7.noarch
pulp-puppet-tools-2.15.1-1.git.4.55208a3.el7.noarch
pulp-python-admin-extensions-2.0.2-1.el7.noarch
pulp-python-plugins-2.0.2-1.el7.noarch
pulp-rpm-admin-extensions-2.15.1-1.git.5.55208a3.el7.noarch
pulp-rpm-plugins-2.15.1-1.git.5.55208a3.el7.noarch
pulp-selinux-2.15.1-1.git.6.55208a3.el7.noarch
pulp-server-2.15.1-1.git.6.55208a3.el7.noarch
python-isodate-0.5.0-4.pulp.el7.noarch
python-kombu-3.0.33-8.pulp.el7.noarch
python-pulp-bindings-2.15.1-1.git.6.55208a3.el7.noarch
python-pulp-client-lib-2.15.1-1.git.6.55208a3.el7.noarch
python-pulp-common-2.15.1-1.git.6.55208a3.el7.noarch
python-pulp-deb-common-1.6.0-1.el7.noarch
python-pulp-docker-common-3.1.1-1.git.3.55208a3.el7.noarch
python-pulp-oid_validation-2.15.1-1.git.6.55208a3.el7.noarch
python-pulp-ostree-common-1.3.0-1.el7.noarch
python-pulp-puppet-common-2.15.1-1.git.4.55208a3.el7.noarch
python-pulp-python-common-2.0.2-1.el7.noarch
python-pulp-repoauth-2.15.1-1.git.6.55208a3.el7.noarch
python-pulp-rpm-common-2.15.1-1.git.5.55208a3.el7.noarch
python-pulp-streamer-2.15.1-1.git.6.55208a3.el7.noarch
</code></pre>
<pre><code class="text syntaxhl" data-language="text">[root@r74-p215n ~]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.4 (Maipo)
</code></pre> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243792018-02-01T17:52:33Zkersom
<ul></ul><p>It seems that code that was merged to fix this issue is not being added as part of the nightly build of Pulp.</p>
<p>As soon as I have more info about it, I will update this issue.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243852018-02-01T19:34:42Zkersom
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>MODIFIED</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=243882018-02-01T19:50:19ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Platform Release</strong> set to <i>2.15.2</i></li></ul><p>There was a mis-understanding, and we goofed up. The fix for this issue is in the master branch, which will at some point turn into a 2.16 release. However, QE assumed that the fix for this issue was present on the 2.15 branch, and was testing against the 2.15 nightlies.</p>
<p>I anticipate that the fix for this issue will be cherry-picked from the master branch onto the 2.15 branch in time for the 2.15.2 release, so I've set the platform release field accordingly. This has the side-effect of fixing spurious test failures.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=246242018-02-19T15:45:50ZAnonymous
<ul></ul><p>Applied in changeset <a class="changeset" title="Actually use rsync_extra_args for all rsync calls Commit c981b94de498 ("As user I want to be abl..." href="https://pulp.plan.io/projects/pulp/repository/pulp/revisions/5f1956a26d63505c75f08608145951571920a5b1">pulp|5f1956a26d63505c75f08608145951571920a5b1</a>.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=246582018-02-20T18:08:58Zdaviddavis
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>5</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=247072018-02-22T16:44:32Zpthomas@redhat.com
<ul></ul><p>The automated test for this is passing.</p> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=248242018-02-28T02:06:27Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>5</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> Pulp - Issue #3317: rsync_distributors: 'rsync_extra_args' not used in all calls to rsynchttps://pulp.plan.io/issues/3317?journal_id=380262019-04-15T20:13:48Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>