https://pulp.plan.io/https://pulp.plan.io/favicon.ico2017-11-28T15:53:01ZPulpPulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=229762017-11-28T15:53:01Zdalleydalley@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>47</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=231102017-11-30T20:59:19Zrchan
<ul><li><strong>Sprint/Milestone</strong> changed from <i>47</i> to <i>48</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=231462017-12-01T20:41:38Zdaviddavis
<ul><li><strong>Tags</strong> <i>Pulp 3 MVP</i> added</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=235012017-12-19T16:17:10Zrchan
<ul><li><strong>Sprint/Milestone</strong> changed from <i>48</i> to <i>52</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=237432018-01-08T21:26:17Zrchan
<ul><li><strong>Sprint/Milestone</strong> changed from <i>52</i> to <i>53</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=243072018-01-30T14:16:13Zjortel@redhat.comjortel@redhat.com
<ul><li><strong>Sprint/Milestone</strong> changed from <i>53</i> to <i>54</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=246962018-02-22T16:22:41Zrchan
<ul><li><strong>Sprint/Milestone</strong> changed from <i>54</i> to <i>56</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=265162018-03-08T23:35:51Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint</strong> set to <i>Sprint 33</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=265372018-03-08T23:36:20Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> deleted (<del><i>56</i></del>)</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=266232018-03-12T12:56:52Zmilan
<ul><li><strong>Assignee</strong> set to <i>milan</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=266472018-03-12T13:57:35Zmilan
<ul><li><strong>Assignee</strong> deleted (<del><i>milan</i></del>)</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=267522018-03-14T16:37:33Zjortel@redhat.comjortel@redhat.com
<ul><li><strong>Sprint Candidate</strong> changed from <i>No</i> to <i>Yes</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=267572018-03-14T16:38:15Zjortel@redhat.comjortel@redhat.com
<ul><li><strong>Sprint</strong> deleted (<del><i>Sprint 33</i></del>)</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=274082018-04-11T15:45:00Zamacdona@redhat.comaustin@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>Pulp 3 MVP</i></del>)</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=301292018-08-14T17:23:53Zbmbouterbmbouter@redhat.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-11 priority-6 priority-default closed" href="/issues/3918">Issue #3918</a>: DeclarativeVersion cannot sync longer than 5 minutes or a timeout error is raised</i> added</li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=301302018-08-14T17:36:26Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>CLOSED - WONTFIX</i></li></ul><p>FYI, In the aiohttp docs now (3.3.2) I see additional options named ['total', 'connect', 'sock_connect', 'sock_read']: <a href="https://aiohttp.readthedocs.io/en/stable/client_quickstart.html#timeouts" class="external">https://aiohttp.readthedocs.io/en/stable/client_quickstart.html#timeouts</a></p>
<p><a class="user active" href="https://pulp.plan.io/users/310">gmbnomis</a> I can see how the plugin writer can do things that make no sense with those types of options. I think they are aiohttp options, so there isn't much Pulp can do to resolve them. aiohttp could have some sanity validation added though, if it doesn't already do that. I recently filed an issue in upstream aiohttp and it was a good experience. Their tracker is here: <a href="https://github.com/aio-libs/aiohttp/issues/" class="external">https://github.com/aio-libs/aiohttp/issues/</a></p>
<p>In terms of what Pulp can do for this, I can only see closing this as WONTFIX since we aren't in control of those options. It's good to leave here as a reference though and WONTFIX will do that. <a class="user active" href="https://pulp.plan.io/users/310">gmbnomis</a>, if you have other ideas of what should happen please post. I just don't see another option.</p> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=301372018-08-14T20:47:03Zgmbnomis
<ul></ul><p><a class="user active" href="https://pulp.plan.io/users/1">bmbouter</a> This issue is not about preventing plugin writers from doing stupid things (life experience tells me that this would be futile...). It was intended as a kind of "heads up" that aiohttp timeouts seem not to be made for long downloads (at that time at least). And apparently that is what happened in <a class="issue tracker-1 status-11 priority-6 priority-default closed" title="Issue: DeclarativeVersion cannot sync longer than 5 minutes or a timeout error is raised (CLOSED - CURRENTRELEASE)" href="https://pulp.plan.io/issues/3918">#3918</a>.</p>
<p>According to the documentation you linked, the <code>sock_read</code> timeout seems to implement the timeout implemented by the <code>wait_for</code> in the code I posted above. Thus, there should be no need for this anymore.</p>
<p>Nevertheless, I think Pulp should have sane default timeout definitions in the downloader for the typical use case (in order to ease the life of plugin writers). Probably, a very long or no total timeout. Connection and read timeouts should probably be in the range of seconds (or minutes?). Are there proven nectar default timeout settings you could reuse?</p> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=415572019-04-25T16:46:03Zdaviddavis
<ul><li><strong>Sprint/Milestone</strong> set to <i>3.0.0</i></li></ul> Pulp - Issue #3149: pulpcore.plugin.download.asyncio has surprising timeout handlinghttps://pulp.plan.io/issues/3149?journal_id=427562019-04-26T20:37:17Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>Pulp 3</i></del>)</li></ul>