https://pulp.plan.io/https://pulp.plan.io/favicon.ico2017-11-08T19:30:41ZPulpDocker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228062017-11-08T19:30:41Zmihai.ibanescu@gmail.commihai.ibanescu@gmail.com
<ul></ul><p>Turns out there is no need to compress anything. Skopeo already compresses the layers.</p> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228072017-11-08T19:33:49Zmihai.ibanescu@gmail.commihai.ibanescu@gmail.com
<ul></ul><p>Proposed patch would be a one-liner if I didn't hate the use of functools when shutils has a perfectly good copyfileobj.</p>
<pre><code>diff --git a/plugins/pulp_docker/plugins/importers/upload.py b/plugins/pulp_docker/plugins/importers/upload.py
index 1ce47b0..780de62 100644
--- a/plugins/pulp_docker/plugins/importers/upload.py
+++ b/plugins/pulp_docker/plugins/importers/upload.py
@@ -22,6 +22,7 @@ import functools
import gzip
import json
import os
+import shutil
import stat
import tarfile
@@ -340,11 +341,8 @@ class AddUnits(PluginStep):
blob_src_path = os.path.join(self.get_working_dir(), item.digest.split(':')[1] + '.tar')
blob_dest_path = os.path.join(self.get_working_dir(), item.digest)
with open(blob_src_path) as blob_src:
- with contextlib.closing(gzip.open(blob_dest_path, 'w')) as blob_dest:
- # these can be big files, so we chunk them
- reader = functools.partial(blob_src.read, 4096)
- for chunk in iter(reader, ''):
- blob_dest.write(chunk)
+ with contextlib.closing(open(blob_dest_path, 'w')) as blob_dest:
+ shutil.copyfileobj(blob_src, blob_dest)
# we don't need the tarfile anymore
os.remove(blob_src_path)
</code></pre> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228262017-11-10T14:04:12Zttereshcttereshc@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>POST</i></li><li><strong>Assignee</strong> set to <i>mihai.ibanescu@gmail.com</i></li></ul><p><a href="https://github.com/pulp/pulp_docker/pull/211" class="external">https://github.com/pulp/pulp_docker/pull/211</a></p> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228272017-11-10T14:05:25Zttereshcttereshc@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/22827/diff?detail_id=23312">diff</a>)</li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228302017-11-10T15:34:47Zdalleydalley@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>47</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228662017-11-14T14:10:23Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>Steps to reproduce and verify:<br>
<a href="https://github.com/pulp/pulp_docker/pull/211#issuecomment-344270012" class="external">https://github.com/pulp/pulp_docker/pull/211#issuecomment-344270012</a></p> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=228672017-11-14T14:12:33ZAnonymous
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="v2 unit import: do not compress blob layers Skopeo produces compressed layers already. Double-co..." href="https://pulp.plan.io/projects/pulp_docker/repository/pulp_docker/revisions/3688b6eeb9261bd11ad1023efb2c6d5facd6c073">3688b6eeb9261bd11ad1023efb2c6d5facd6c073</a>.</p> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=230072017-11-29T02:22:07Zpcreechpcreech@redhat.com
<ul><li><strong>Platform Release</strong> set to <i>2.15.0</i></li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=230752017-11-30T18:29:40Zpcreechpcreech@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>5</i></li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=232962017-12-14T16:44:00ZIchimonji10jerebear@protonmail.com
<ul></ul><p>@preethi I don't think this issue should be automated at this time. Doing so requires adding a dependency on skopeo, and we have enough other things to do without adding another dependency.</p> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=240122018-01-17T21:08:59Zpcreechpcreech@redhat.com
<ul><li><strong>Status</strong> changed from <i>5</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=262822018-03-08T23:26:25Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint</strong> set to <i>Sprint 28</i></li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=263042018-03-08T23:27:48Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> deleted (<del><i>47</i></del>)</li></ul> Docker Support - Issue #3122: config layer is served gzip-compressed to docker clienthttps://pulp.plan.io/issues/3122?journal_id=381032019-04-15T20:15:10Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>