https://pulp.plan.io/https://pulp.plan.io/favicon.ico2017-04-21T12:41:29ZPulpCrane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192802017-04-21T12:41:29Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>can you please show your crane.conf? specifically to what points the data_dir</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192812017-04-21T14:07:17ZIchimonji10jerebear@protonmail.com
<ul></ul><p><code>/etc/crane.conf</code>:</p>
<pre><code># See:
#
# * https://docs.pulpproject.org/plugins/pulp_docker/user-guide/recipes.html
# * https://docs.pulpproject.org/plugins/crane/index.html
# * https://pulp.plan.io/issues/2700
# * https://pulp.plan.io/issues/2717
#
[general]
data_dir: /var/lib/pulp/published/docker
debug: false
</code></pre>
<p><code>/etc/httpd/conf.d/pulp_crane.conf</code>:</p>
<pre><code># Place this config in /etc/httpd/conf.d/. Use with Apache 2.4+. See:
#
# * https://docs.pulpproject.org/plugins/crane/index.html
# * https://modwsgi.readthedocs.io/en/develop/user-guides/quick-configuration-guide.html
#
Listen 5000
<VirtualHost *:5000>
WSGIScriptAlias / /usr/share/crane/crane.wsgi
<Directory /usr/share/crane/>
Require all granted
</Directory>
</VirtualHost>
</code></pre>
<p>By the way, docker works with these published repositories. Commands like <code>docker pull localhost:5000/repo-name</code> succeed.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192822017-04-21T14:20:09Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>when you created repo foo you needed to disable v2 and enable v1 like mentioned in recipes <a href="https://docs.pulpproject.org/plugins/pulp_docker/user-guide/recipes.html#sync" class="external">https://docs.pulpproject.org/plugins/pulp_docker/user-guide/recipes.html#sync</a><br>
basically both repos are v2 content. that's why you don't see the v1 content.</p>
<p>if you do like in docs eventually you will see:</p>
<pre><code>{
"synctest": {
"image_ids": [],
"protected": false,
"tags": {}
},
"v1synctest": {
"image_ids": [
"29017da868fba2d82fca0c416f5a91d3744bc8269a8b8ad0968a31837bf018bd",
"4db501ca0880e5791368fa81e339ebb86ec2f2f6354abfe6b44f4b0304fadb00",
"ff8f955d1fed83a6239675b9a767fc9502db9934922a2f69ac6bf4cad8a7d7be",
"f1e4b055fb652a75379f41aee7b23a23a5f6dcc3b07e61f181d542ebb04f2ac9",
"437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1",
"2b8777f8541c6d03f7995f22506ecf4e4b3aaf73dc30a227844ab7c4cca16927",
"d7057cb020844f245031d27b76cb18af05db1cc3a96a29fa7777af75f5ac91a3",
"1c677c871a78a34d8af0f934762c121cb67c5ca9eb7f7aa82e031ad4f46d7b49",
"bf0f46991aed1fa45508683e740601df23a2395c47f793883e4b0160ab906c1e",
"79722f6accc3345ac95c95dd5dd4af5563cd68a04691e728df4724fc8e8ad581",
"71571befa96b398b6fcb5640c22e118c52e4cd822e44dcf2241174c1f45818fa",
"920777304d1d5e337bc59877253e946f224df5aae64c72538672eb74637b3c9e",
"77608b59d92f23a988df653ad660e91e04c72d20bfaf1a7f06ae6a6a79331482",
"c058d2db34b192789daa4c7c304f87f491b5602ca150328f726035e31efb3550",
"633fcd11259e8d6bccfbb59a4086b95b0d0fb44edfc3912000ef1f70e8a7bfc6",
"b65c936b5fb601d680ed656b1ccf8ab857c0e5cb521043a005405c194e9a69f3",
"b84f77d69dcdac49a32315fde9274b726472505cd5edb0bdf112eadb64de060c",
"2f0c79238b2fd6eed3ca4bea9b3b22388f9bc1d9882a18121fba9c2e4cee300a",
"cfa753dfea5e68a24366dfba16e6edf573daa447abf65bc11619c1a98a3aff54",
"c2ddbea624bdf70a9c1b1e843d48065509f4a631d8723aa347b401aebbf7ec98",
"0f864637f229eee9da53fd5591fb58138b6bfb0196f0ee4fd9417d3655fb3d28",
"79e69b372961d11d555c12fe0e2f0e8893abffb38ef43ef3eb479a3b654ae265",
"cf2616975b4a3cba083ca99bc3f0bf25f5f528c3c52be1596b30f60b0b1c37ff",
"118a2fc47f99753bb828e50ef6d586c9013ade6f8739b9b64650ad1b3ecd0eb2",
"3d5bcd78e074f6f77b820bf4c6db0e05d522e24c855f3c2a3bbf3b1c8f967ba8",
"5f7820582aae34a153bd540c057ba80f62e94ad5cfab23a1f9533df984167748",
"a6dbc8d6ddbb9e905518a9df65f414efce038de5f253a081b1205c6cea4bac17"
],
"protected": false,
"tags": {
"1-ubuntu": "a6dbc8d6ddbb9e905518a9df65f414efce038de5f253a081b1205c6cea4bac17",
"1.21-ubuntu": "a6dbc8d6ddbb9e905518a9df65f414efce038de5f253a081b1205c6cea4bac17",
"1.21.0-ubuntu": "a6dbc8d6ddbb9e905518a9df65f414efce038de5f253a081b1205c6cea4bac17",
"1.23": "d7057cb020844f245031d27b76cb18af05db1cc3a96a29fa7777af75f5ac91a3",
"1.23.2": "d7057cb020844f245031d27b76cb18af05db1cc3a96a29fa7777af75f5ac91a3",
"1.24": "437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1",
"1.24-glibc": "c058d2db34b192789daa4c7c304f87f491b5602ca150328f726035e31efb3550",
"1.24-musl": "71571befa96b398b6fcb5640c22e118c52e4cd822e44dcf2241174c1f45818fa",
"1.24-uclibc": "437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1",
"1.24.0": "3d5bcd78e074f6f77b820bf4c6db0e05d522e24c855f3c2a3bbf3b1c8f967ba8",
"1.24.1": "f1e4b055fb652a75379f41aee7b23a23a5f6dcc3b07e61f181d542ebb04f2ac9",
"1.24.1-glibc": "118a2fc47f99753bb828e50ef6d586c9013ade6f8739b9b64650ad1b3ecd0eb2",
"1.24.1-musl": "29017da868fba2d82fca0c416f5a91d3744bc8269a8b8ad0968a31837bf018bd",
"1.24.1-uclibc": "f1e4b055fb652a75379f41aee7b23a23a5f6dcc3b07e61f181d542ebb04f2ac9",
"1.24.2": "437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1",
"1.24.2-glibc": "c058d2db34b192789daa4c7c304f87f491b5602ca150328f726035e31efb3550",
"1.24.2-uclibc": "437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1",
"buildroot-2013.08.1": "1c677c871a78a34d8af0f934762c121cb67c5ca9eb7f7aa82e031ad4f46d7b49",
"buildroot-2014.02": "0f864637f229eee9da53fd5591fb58138b6bfb0196f0ee4fd9417d3655fb3d28",
"ubuntu": "a6dbc8d6ddbb9e905518a9df65f414efce038de5f253a081b1205c6cea4bac17",
"ubuntu-12.04": "ff8f955d1fed83a6239675b9a767fc9502db9934922a2f69ac6bf4cad8a7d7be",
"ubuntu-14.04": "633fcd11259e8d6bccfbb59a4086b95b0d0fb44edfc3912000ef1f70e8a7bfc6"
}
}
}
</code></pre>
<p>But the issues still persists here, the code needs to be updated, to parse the v2_data, seems like this was not working since we added v2 api support</p>
<p><a href="https://github.com/pulp/crane/blob/master/crane/app_util.py#L186" class="external">https://github.com/pulp/crane/blob/master/crane/app_util.py#L186</a></p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192832017-04-21T14:40:25ZIchimonji10jerebear@protonmail.com
<ul></ul><p>Gotcha. <code>pulp-admin docker repo create --help</code> states that v1 content is synced by default. Is this a bug?</p>
<pre><code>[root@fedora-24-pulp-2-12 ~]# pulp-admin docker repo create --help
Command: create
Description: creates a new repository
Available Arguments:
[snip!]
--enable-v1 - Enable sync of v1 API. defaults to "true"
--enable-v2 - Enable sync of v2 API. defaults to "true"
[snip!]
</code></pre>
<p>EDIT: I see the same output on a Pulp 2.14 system too.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192912017-04-21T15:21:50Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>ipanova@redhat.com</i></li><li><strong>Sprint/Milestone</strong> set to <i>37</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192922017-04-21T15:22:41Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Severity</strong> changed from <i>2. Medium</i> to <i>3. High</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192942017-04-21T15:29:58Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=192952017-04-21T15:49:06ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Subject</strong> changed from <i>/crane/repositories incorrectly states that repositories are empty</i> to <i>GET /crane/repositories doesn't report content of v2 repositories</i></li></ul><p>After some discussion with the developers, it turns out that HTTP GET requests to /crane/repositories will reveal v1 content, but not v2 content. I've updated the issue title accordingly.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=194462017-05-01T14:15:53Zjortel@redhat.comjortel@redhat.com
<ul><li><strong>Sprint/Milestone</strong> changed from <i>37</i> to <i>38</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=194992017-05-05T10:40:24Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Add endpoint /crane/repositories/v2 to display v2 repositories. closes #2723 https://pulp.plan.i..." href="https://pulp.plan.io/projects/crane/repository/23/revisions/71b7707f71a58725d93241777cc1379cb1bc6630">71b7707f71a58725d93241777cc1379cb1bc6630</a>.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=195002017-05-05T11:03:53Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Subject</strong> changed from <i>GET /crane/repositories doesn't report content of v2 repositories</i> to <i>As a user GET /crane/repositories/v2 shows v2 repositories</i></li><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>POST</i></li></ul><p><a href="https://github.com/pulp/crane/pull/72" class="external">https://github.com/pulp/crane/pull/72</a></p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=197712017-05-19T09:37:38Zipanova@redhat.comipanova@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Add endpoint /crane/repositories/v2 to display v2 repositories. closes #2723 https://pulp.plan.i..." href="https://pulp.plan.io/projects/crane/repository/23/revisions/a6c6e764e20b46c273074cca4b2c8079a5ea1c1d">a6c6e764e20b46c273074cca4b2c8079a5ea1c1d</a>.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=198682017-05-23T16:16:55ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>ASSIGNED</i></li></ul><p>This issue doesn't appear to have been fixed. The relevant tests are failing in Jenkins, and I can reproduce the issue 100% of the time. To reproduce this issue, I spun up a matrix of nine VMs, where the axes are:</p>
<ul>
<li>Pulp 2.13 beta, 2.13 nightly, 2.14 nightly</li>
<li>Fedora 24, Fedora 25, RHEL 7</li>
</ul>
<p>I then executed the automated tests which target this issue:</p>
<pre><code class="sh syntaxhl" data-language="sh">python <span class="nt">-m</span> unittest <span class="se">\</span>
pulp_smash.tests.docker.cli.test_sync_publish.RepoRegistryIdTestCase <span class="se">\</span>
pulp_smash.tests.docker.cli.test_sync_publish.SyncNonNamespacedV2TestCase <span class="se">\</span>
pulp_smash.tests.docker.cli.test_sync_publish.SyncPublishV2TestCase
</code></pre>
<p>All tests failed. For debugging purposes, I used some <code>pprint()</code> statements to print out the responses to GET /crane/repositories. Here's the output of one of those statements, where the JSON has been encoded as Python:</p>
<pre><code class="python syntaxhl" data-language="python"><span class="p">{</span><span class="s">'b83a36a1-4393-48a4-a722-6fde0d5c368d'</span><span class="p">:</span> <span class="p">{</span><span class="s">'image_ids'</span><span class="p">:</span> <span class="p">[],</span>
<span class="s">'protected'</span><span class="p">:</span> <span class="bp">False</span><span class="p">,</span>
<span class="s">'tags'</span><span class="p">:</span> <span class="p">{}}}</span>
</code></pre> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=198852017-05-24T14:23:52Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> changed from <i>38</i> to <i>39</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=198862017-05-24T14:44:26Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>I just checked, it looks like it is in working state.<br>
1) did you check that repo 'b83a36a1-4393-48a4-a722-6fde0d5c368d' actually has the v1 content?<br>
2) Also please mind this note <a href="https://github.com/pulp/crane/pull/72#issue-229358800" class="external">https://github.com/pulp/crane/pull/72#issue-229358800</a><br>
3) And this <a href="https://github.com/pulp/crane/pull/72/files#diff-caf2a6b8f4947d018f68893c695b5202R173" class="external">https://github.com/pulp/crane/pull/72/files#diff-caf2a6b8f4947d018f68893c695b5202R173</a></p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=199262017-05-29T16:19:37Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>@ Ichimonji10 also would be good to check not just api representation but html as well.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=199372017-05-30T18:20:54ZIchimonji10jerebear@protonmail.com
<ul></ul><blockquote>
<p>1) did you check that repo 'b83a36a1-4393-48a4-a722-6fde0d5c368d' actually has the v1 content?</p>
</blockquote>
<p>It has no v1 content.</p>
<blockquote>
<p>2) Also please mind this note <a href="https://github.com/pulp/crane/pull/72#issue-229358800" class="external">https://github.com/pulp/crane/pull/72#issue-229358800</a></p>
</blockquote>
<p>Ahh. The automated test was wrong-ish. Thanks.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=199442017-05-30T19:55:59ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>MODIFIED</i></li></ul><p>So, the fix is a little bit different than I expected: only the "protected" property is visible for v2 repositories. It works as described for the nightly builds of Pulp 2.14 and above.</p> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=211272017-07-20T18:40:22Zpcreechpcreech@redhat.com
<ul><li><strong>Platform Release</strong> set to <i>2.14.0</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=212402017-07-27T15:15:28Zpcreechpcreech@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>5</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=216072017-08-15T14:17:45Zpcreechpcreech@redhat.com
<ul><li><strong>Status</strong> changed from <i>5</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=259812018-03-08T23:14:24Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint</strong> set to <i>Sprint 20</i></li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=260052018-03-08T23:15:49Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> deleted (<del><i>39</i></del>)</li></ul> Crane - Issue #2723: As a user GET /crane/repositories/v2 shows v2 repositorieshttps://pulp.plan.io/issues/2723?journal_id=383072019-04-15T20:18:46Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>