Project

Profile

Help

Issue #2623

closed

Errata publish performace degradation

Added by ttereshc about 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.12.2
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 16
Quarter:

Description

pulp-admin rpm repo create --repo-id epel7 --relative-url epel7 --feed https://dl.fedoraproject.org/pub/epel/7/x86_64/ --download-policy on_demand
pulp-admin rpm repo sync  run --repo-id epel7

Notice that publish of errata is extremely slow, several seconds per each erratum.
My tests shows that it is because of this recent errata fix.


Related issues

Related to RPM Support - Issue #2560: Non-unique collection names in erratum pkglists causes yum not to show all packagesCLOSED - CURRENTRELEASEsemyersActions
Actions #1

Updated by semyers about 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to semyers

I feel like we worked pretty hard to keep the performance the same, so I'll take a look. If the cause of the slowdown is not obvious or simple to fix then I propose to just revert my PR, fix the bug the initial (and terrible way) I did, open up a separate refactor issue referencing the reverted commit, and we can get the new errata behavior in formally with 2.13.

Actions #2

Updated by bizhang about 7 years ago

  • Sprint/Milestone set to 34
  • Triaged changed from No to Yes

Added by semyers about 7 years ago

Revision f93b8dc9 | View on GitHub

Don't rebuild repo_unit_nevra for every unit

This made errata publish very slow.

closes #2623 https://pulp.plan.io/issues/2623

Actions #3

Updated by semyers about 7 years ago

  • Related to Issue #2560: Non-unique collection names in erratum pkglists causes yum not to show all packages added
Actions #4

Updated by semyers about 7 years ago

  • Status changed from ASSIGNED to POST
Actions #5

Updated by semyers about 7 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by semyers about 7 years ago

  • Platform Release set to 2.12.2
Actions #7

Updated by semyers about 7 years ago

  • Status changed from MODIFIED to 5
Actions #8

Updated by semyers about 7 years ago

This is a little odd, since it was broken and fixed between the 2.12.1 and 2.12.2 releases. If we want to verify this, it would be to ensure there's little to no difference between the performance of publishing errata in 2.12.1 and 2.12.2.

Actions #9

Updated by bizhang about 7 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #12

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 16
Actions #13

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (34)
Actions #14

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF