https://pulp.plan.io/https://pulp.plan.io/favicon.ico2017-03-06T18:35:42ZPulpRPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183572017-03-06T18:35:42ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/18357/diff?detail_id=19097">diff</a>)</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183582017-03-06T18:36:36ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/18358/diff?detail_id=19098">diff</a>)</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183592017-03-06T18:37:32ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/18359/diff?detail_id=19099">diff</a>)</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183602017-03-06T18:55:03Zsemyerssean.myers@redhat.com
<ul></ul><p>Ichimonji10 wrote:</p>
<blockquote>
<p>This error is present for Pulp 2.12 and 2.13 on all supported platforms. ...</p>
</blockquote>
<p>Do you know if this error is present for both 2.12.0 and 2.12.1, or if it's just 2.12.1?</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183612017-03-06T19:00:37ZIchimonji10jerebear@protonmail.com
<ul></ul><blockquote>
<p>Do you know if this error is present for both 2.12.0 and 2.12.1, or if it's just 2.12.1?</p>
</blockquote>
<p>AFAIK, it's only present for the development versions of 2.12.1 and 2.13. I didn't observe it in the 2.12.1 release.</p>
<p>Issue updated to state "2.12 and 2.13 nightlies."</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183622017-03-06T19:01:16ZIchimonji10jerebear@protonmail.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/18362/diff?detail_id=19100">diff</a>)</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183712017-03-06T22:53:44Zsemyerssean.myers@redhat.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Severity</strong> changed from <i>2. Medium</i> to <i>3. High</i></li></ul><p>Tentatively marking as a blocker for 2.12.z+, and raising the prio/sev each to high accordingly for a release blocker, pending review by the team during triage tomorrow.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183722017-03-07T09:00:35Zttereshcttereshc@redhat.com
<ul></ul><p>+1 for blocker</p>
<p>During search all the units data from db is selected including gzipped XML snippets for RPM/SRPM units, and this issue happens when json module tries to serialize this data to generate response.<br>
I have not found any other calls affected by the similar issue.</p>
<p>It is possible to solve this issue in two ways I think:<br>
- <del>do not return to user these XML snippets at all</del><br>
- unzip the data and return it to user</p>
<p><del>I am leaning towards the first option. These XML snippets are needed only for publish purposes and during search we just return everything we have in DB including such data which is meant to be for internal use only.<br>
This is a hacky way but just to show that one way or the other we can exclude 'repodata' from the units data:</del></p>
<pre><code class="diff syntaxhl" data-language="diff"><span class="gh">diff --git a/server/pulp/server/webservices/views/repositories.py b/server/pulp/server/webservices/views/repositories.py
index e0389c8..6ef4943 100644
</span><span class="gd">--- a/server/pulp/server/webservices/views/repositories.py
</span><span class="gi">+++ b/server/pulp/server/webservices/views/repositories.py
</span><span class="p">@@ -291,6 +291,7 @@</span> class RepoUnitSearch(search.SearchView):
units = manager.get_units(repo_id, criteria=criteria)
for unit in units:
content.remap_fields_with_serializer(unit['metadata'])
<span class="gi">+ unit['metadata'].pop('repodata', None)
</span> return generate_json_response_with_pulp_encoder(units)
</code></pre>
<p><del>The potential downside(?) that we no longer return XML snippets like we did before, though I can't come up with a use case when this data may be needed for someone</del>.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183752017-03-07T14:15:30ZIchimonji10jerebear@protonmail.com
<ul></ul><blockquote>
<p>During search all the units data from db is selected including gzipped XML snippets for RPM/SRPM units,</p>
</blockquote>
<p>This is consistent with Pulp's behaviour. Tests which search for DRPM units are not affected, as I discovered while walking through the failing tests and writing up <a href="https://github.com/PulpQE/pulp-smash/pull/575" class="external">Pulp Smash #575</a>.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183782017-03-07T15:44:24Zbizhangbizhang@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>34</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183812017-03-07T15:58:45Zipanova@redhat.comipanova@redhat.com
<ul></ul><p>I confirm that it happens just with rpm and srpm.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183822017-03-07T16:01:34Zdaviddavis
<ul></ul><p>Could you maybe use projection to not return the field?</p>
<p><a href="https://docs.mongodb.com/manual/tutorial/project-fields-from-query-results/" class="external">https://docs.mongodb.com/manual/tutorial/project-fields-from-query-results/</a></p>
<p>Regardless, option 1 sounds good to me.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183832017-03-07T16:07:24Zjortel@redhat.comjortel@redhat.com
<ul></ul><p>Seems like not returning the metadata would perform better but won't that break semantic versioning by altering the data returned by the API.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183932017-03-07T21:57:27Zsemyerssean.myers@redhat.com
<ul></ul><p>We chatted about this in IRC and agree that option 1 would probably break semver, leaving option 2. ttereshc has updated comment 8 accordingly.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=183942017-03-08T10:53:34Zttereshcttereshc@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>ttereshc</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=184142017-03-09T17:23:14Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li></ul><p>After a lot of investigation, and a process of elimination going through successively less simple solutions, we put together these PRs to fix views affected by this (hopefully) without breaking anything else:<br>
<a href="https://github.com/pulp/pulp/pull/2962" class="external">https://github.com/pulp/pulp/pull/2962</a><br>
<a href="https://github.com/pulp/pulp_rpm/pull/1037" class="external">https://github.com/pulp/pulp_rpm/pull/1037</a></p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=184152017-03-09T18:00:38Zttereshcttereshc@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li></ul><p>Applied in changeset <a class="changeset" title="Replace remap_fields with serialize_unit In order to fix an RPM bug, an opportunity presented it..." href="https://pulp.plan.io/projects/pulp/repository/pulp/revisions/22efbda46d8e3e3f8d6068b6cd9cd353b677e2e2">pulp:pulp|22efbda46d8e3e3f8d6068b6cd9cd353b677e2e2</a>.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=184172017-03-09T18:07:14Zsemyerssean.myers@redhat.com
<ul><li><strong>Platform Release</strong> set to <i>2.12.2</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=184782017-03-10T21:16:29Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>5</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=185842017-03-16T20:22:29Zsemyerssean.myers@redhat.com
<ul></ul><p>We had a good team chat about the "Verification Required" flag on Monday, and decided that the release of 2.12.2 should not be blocked on the verification of this issue.</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=185862017-03-16T20:24:34ZIchimonji10jerebear@protonmail.com
<ul></ul><blockquote>
<p>We had a good team chat about the "Verification Required" flag on Monday, and decided that the release of 2.12.2 should not be blocked on the verification of this issue.</p>
</blockquote>
<p>Hunh? This issue is already verified. The 2.12.2 release wouldn't be blocked no matter the status of the "Verification Required" flag on this issue.</p>
<p>Also, this issue should <em>definitely</em> block the 2.12.2 release. (But the issue is fixed and has been verified, so there's no need to block.)</p> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=191232017-04-12T14:17:46Zbizhangbizhang@redhat.com
<ul><li><strong>Status</strong> changed from <i>5</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=196022017-05-12T13:02:28Zdaviddavis
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-1 status-12 priority-6 priority-default closed" href="/issues/2753">Issue #2753</a>: Cannot search rpm content from the CLI</i> added</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=258282018-03-08T22:42:29Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint</strong> set to <i>Sprint 16</i></li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=258462018-03-08T23:05:33Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> deleted (<del><i>34</i></del>)</li></ul> RPM Support - Issue #2620: All RPM repo searches are brokenhttps://pulp.plan.io/issues/2620?journal_id=383942019-04-15T20:20:22Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>