Project

Profile

Help

Task #2576

closed

Update build system to properly implement el6 support policy

Added by semyers about 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.12.1
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

This means:

  • pulp.spec needs to be updated to no longer build unsupported packages for el6, but continue to build the ones we do support (pulp-agent, pulp-consumer, related deps, and no plugins)

...but this also means:

  • nightly builder and PR testers should build/test unsupported el6 packages to protect us against making a breaking change on el6 that will impact downstream projects still supporting el6

I thought I'd already prevented the release of unsupported packages (albeit manually) for 2.12.0, but that process failed, so I think we need to bake this directly into the build automation.


Related issues

Related to Pulp - Issue #2583: Pulp installation failing in nightly buildsCLOSED - CURRENTRELEASEsemyersActions

Added by semyers about 7 years ago

Revision 367ea579 | View on GitHub

Stop building unsupported packages for el6

This requires a corresponding change to our build system to allow us to continue building and testing el6 packages nightly, but it seems best to have the committed spec file reflect the current support policy.

I wasn't actually sure that the change would be this simple, so I did a test build with the change in place, here's what got built for el6:

  • pulp-agent
  • pulp-consumer-client
  • python-pulp-agent-lib
  • python-pulp-bindings
  • python-pulp-client
  • python-pulp-common
  • python-pulp-devel

re #2576 https://pulp.plan.io/issues/2576

Added by semyers about 7 years ago

Revision 367ea579 | View on GitHub

Stop building unsupported packages for el6

This requires a corresponding change to our build system to allow us to continue building and testing el6 packages nightly, but it seems best to have the committed spec file reflect the current support policy.

I wasn't actually sure that the change would be this simple, so I did a test build with the change in place, here's what got built for el6:

  • pulp-agent
  • pulp-consumer-client
  • python-pulp-agent-lib
  • python-pulp-bindings
  • python-pulp-client
  • python-pulp-common
  • python-pulp-devel

re #2576 https://pulp.plan.io/issues/2576

Actions #1

Updated by semyers about 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to semyers

We need this for 2.12.1 (really should have had it for 2.12.0, as mentioned in the description). I've already started tinkering with the build system, but wanted to get a ticket up to track the changes being made, as well as why they're being made.

Actions #2

Updated by semyers about 7 years ago

  • Platform Release set to 2.12.1

Added by semyers about 7 years ago

Revision b088be6a | View on GitHub

Build scripts filter out unsupported dists by default

With the changes to our support policy, it's become necessary for release engineering sanity to bake the idea of supported distributions into the build scripts and related libraries.

Since we still want nightlies and the PR tester to give us feedback if something we do needlessly breaks el6, the nightly build job has been updated to include unsupported distributions when building packages.

This commit is also peppered with linting, as well as more preparatory work getting us ready to switch to python3 when building pulp (mainly because we can, and the work is largely already done).

closes #2576 https://pulp.plan.io/issues/2576

Actions #3

Updated by semyers about 7 years ago

  • Status changed from ASSIGNED to MODIFIED
  • % Done changed from 0 to 100
Actions #4

Updated by semyers about 7 years ago

  • Related to Issue #2583: Pulp installation failing in nightly builds added
Actions #5

Updated by semyers about 7 years ago

#2583 was caused by the changes for this issue, but after testing I think I've got the build system and pulp spec all fixed, properly implementing our support policy. The build system picked up the new "--build-unsupported" option that still allows us to build packages for unsupported platforms when desired.

The referenced commits get the build system in-shape for future (>=2.12.1) releases, but rebuilding 2.12.0 for el6 has proven to be more difficult, since that has already been released and doesn't get destined to land in 2.12.1, like those found in 367ea579.

The work to make it possible to release only supported packages for el6 is now done, however, so we can now re-release 2.12.0 for el6, with all unsupported packages removed. We may need to help users on el6 roll back to 2.11.z (or be persuasive with regard to upgrading to el7), in the event that any el6 users have upgraded to 2.12.0. I think it may be appropriate to set the platform release to "2.12.0", and issue the fixed release for el6 as 2.12.0-2, but want to consult with the team before throwing that switch. It's already on the agenda for a meeting on Monday; this should be resolved well before the 2.12.1 GA.

Actions #6

Updated by bizhang about 7 years ago

  • Status changed from MODIFIED to 5
Actions #7

Updated by bizhang about 7 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF