Pulp

Which http result code should be returned when the streamer tries multiple catalog entries? The choices seem to be:

• always return 404
• return the http code for the last entry tried.

Either could be a little misleading and user might have to look at the log to determine what happened. I'm leaning toward return the last code because it will likely be the most accurate in more cases. Especially for cases where only 1 catalog entry exists.

Thoughts?

I think the response code should be chosen within the context of the current requester and responder, and should not consider context of 3rd-party interactions. A client requests a file. The streamer tries to return it, but can't find it. The client doesn't care why. Filesystem permission error, selinux, file isn't on disk where it should be, auth error to a remote source, etc. Regardless of the reason, the streamer wasn't able to find the file. It should return a 404.

Here is the official definition, which I think fits perfectly: https://tools.ietf.org/html/rfc7231#section-6.5.4

Logging reasons for failures of each catalog entry would be a great idea though.

mhrivnak wrote:

I think the response code should be chosen within the context of the current requester and responder, and should not consider context of 3rd-party interactions. A client requests a file. The streamer tries to return it, but can't find it. The client doesn't care why. Filesystem permission error, selinux, file isn't on disk where it should be, auth error to a remote source, etc. Regardless of the reason, the streamer wasn't able to find the file. It should return a 404.

I do like the low-complexity and deterministic nature of this approach.

I do agree that we need to return 404 in the mentioned above situations.

PR, updated.