Project

Profile

Help

Story #2517

closed

As a user I can continue to sync rest of the repo after corrupted manifest is encountered

Added by ipanova@redhat.com about 7 years ago. Updated almost 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Target Release - Docker:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

During download of manifests step if one of the manifests is corrupted we finish the sync right away without giving the possibility to sync subsequent manifests in the repo.
We should log the error in the task progress report and continue to sync other manifests.
When sync completes we should mark the task status as failed with logged errors and problematic manifests.


$ pulp-admin docker  repo  sync run --repo-id=synctest

+----------------------------------------------------------------------+
                  Synchronizing Repository [synctest]
+----------------------------------------------------------------------+

This command may be exited via ctrl+c without affecting the request.

Downloading manifests
[-]

Task Failed

The Manifest digest does not match the expected value. The remote feed announced
a digest of
sha256:aaaaaaaaaaaaaaaa but the
downloaded digest was
sha256:bbbbbbbbbbbbbbbb.

$ pulp-admin -v docker repo list

+----------------------------------------------------------------------+
                          Docker Repositories
+----------------------------------------------------------------------+

Id:                  synctest
Display Name:        None
Description:         None
Content Unit Counts: 

As you can see no content at all was synced because first processed manifest was corrupted and this prevented us to sync the rest of the content. We should change the behaviour.

Actions #1

Updated by ipanova@redhat.com about 7 years ago

mhrivnak, w/r to marking the overall Task as failed, i still lean more towards to mark it as succeeded but log the errors in the Task report.
I would like to hear more opinions on this.

Actions #3

Updated by ipanova@redhat.com about 7 years ago

After some debugging and discussion with mhrivnak we decided not to do this improvement now due to the fact it can bring instability and regression, because of a lot of changes in the code which would lead to changes in behaviour. Docker plugin does not have its own progress report which we would need to implement, in addition we would need to create its own status-renderer.

Actions #4

Updated by bmbouter about 7 years ago

To give an opinion in response to comment 1. For Pulp 2.y and Pulp3, if its a fatal exception the task should fail and it should fail immediately. For a non-fatal exception, the task should complete, be marked as successful, and task error recorded in the report. This sounds like a non-fatal exception so marking the overall task state as succeeded is what I would expect.

Actions #5

Updated by bmbouter almost 5 years ago

  • Status changed from NEW to CLOSED - WONTFIX
Actions #6

Updated by bmbouter almost 5 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

Actions #7

Updated by bmbouter almost 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF