Issue #2464
closedpulp-admin broken in vagrant environment on 2.y
Description
Okaara 1.0.36 is incompatible with the Python 2.7.12 runtime. I filed that issue here[0]. Fortunately, all distributions we run on have 1.0.35- so users are not affected[1], but when I vagrant up using the head of pulp/devel:master I receive Okaara from PyPI which was bumped to 1.0.26 on Oct 14th.
[0]: https://github.com/jdob/okaara/issues/16
[1]: https://apps.fedoraproject.org/packages/python-okaara
Updated by bmbouter over 7 years ago
Resolved this issue locally with this patch which updates the spec file and setup.py to require a version 1.0.32 <= python-okaara < 1.0.36. I'm not opening a PR on this because I want to hear from others if this is the way to go. I don't think we need to port this to pulp/packaging[0] because I suspect we won't use okaara in Pulp3.
diff --git a/client_lib/setup.py b/client_lib/setup.py
index a697677..03732f8 100755
--- a/client_lib/setup.py
+++ b/client_lib/setup.py
@@ -9,5 +9,5 @@ setup(
packages=find_packages(exclude=['test']),
author='Pulp Team',
author_email='pulp-list@redhat.com',
- install_requires=['isodate>0.5.0', 'm2crypto', 'okaara>=1.0.32', 'setuptools']
+ install_requires=['isodate>0.5.0', 'm2crypto', 'okaara>=1.0.32,<1.0.36', 'setuptools']
)
diff --git a/pulp.spec b/pulp.spec
index 0350ee6..cd879d4 100644
--- a/pulp.spec
+++ b/pulp.spec
@@ -787,7 +787,7 @@ Summary: Pulp client extensions framework
Group: Development/Languages
Requires: m2crypto
Requires: python-%{name}-common = %{pulp_version}
-Requires: python-okaara >= 1.0.32
+Requires: python-okaara >= 1.0.32,python-okaara < 1.0.36
Requires: python-isodate >= 0.5.0-1.pulp
Requires: python-setuptools
Obsoletes: pulp-client-lib
This patch syntax was informed from these pages[1][2].
[0]: https://github.com/pulp/packaging
[1]: https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers
[2]: https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch-specfile-syntax.html
Added by bmbouter over 7 years ago
Added by bmbouter over 7 years ago
Revision a1b5671f | View on GitHub
Pins okaara dependency versions
The okaara 1.0.36 release is incompatible with Python 2.7. This Pins the versions to 1.0.32 <= okaara <= 1.0.35 which are compatible with Pulp. This range limit is made in the spec file and the setup.py requirements.
Updated by bmbouter over 7 years ago
- Status changed from NEW to POST
- Assignee set to bmbouter
- Sprint/Milestone set to 30
This already has a patch that I need to maintain locally for vagrant to work. PR is now available here: https://github.com/pulp/pulp/pull/2892
This PR is against 2.8-dev because I think we want Vagrant to work back that far.
Updated by bmbouter over 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|a1b5671f49ef505e6e683ba99d040eb0d9820721.
Updated by semyers over 7 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
Pins okaara dependency versions
The okaara 1.0.36 release is incompatible with Python 2.7. This Pins the versions to 1.0.32 <= okaara <= 1.0.35 which are compatible with Pulp. This range limit is made in the spec file and the setup.py requirements.
https://pulp.plan.io/issues/2464 closes #2464