Issue #2441
closed
unassociating a docker_manifest removes docker_blob regardless of whether or not other docker_manifest in repo reference it
Description
reproducer:
repo content:
Manifest: sha256:70753876404a22bc39af3ddcae831f9f2d32950f27f964dd781c66da051be957
|- Blob: sha256:6e0419422ad90f146b41a787cbfa826ee3dd372b1dc0e3f100dbd71d5b63d47d
|- Blob: sha256:16dc1f96e3a1bb628be2e00518fec2bb97bd5933859de592a00e2eb7774b6ecf
Manifest: sha256:c7a76dc3a509a42c9af781674826ed5c107017299aea2f10b06e658abbe5299f
|- Blob: sha256:c157e91881d411d2e1847078ae5635d2b52f947ad07c218e248806768700fcdb
|- Blob: sha256:16dc1f96e3a1bb628be2e00518fec2bb97bd5933859de592a00e2eb7774b6ecf
1. unassociate {"filters": {"unit": {"digest": "sha256:c7a76dc3a509a42c9af781674826ed5c107017299aea2f10b06e658abbe5299f"}}}
2. Result:
repo doesn't have sha256:c157e91881d411d2e1847078ae5635d2b52f947ad07c218e248806768700fcdb
repo doesn't have sha256:16dc1f96e3a1bb628be2e00518fec2bb97bd5933859de592a00e2eb7774b6ecf
Expected behaviour:
repo doesn't have sha256:c157e91881d411d2e1847078ae5635d2b52f947ad07c218e248806768700fcdb
repos DOES have sha256:16dc1f96e3a1bb628be2e00518fec2bb97bd5933859de592a00e2eb7774b6ecf
Updated by ipanova@redhat.com over 7 years ago
- Description updated (diff)
It was reproduced on 2.8 and master as well
Updated by ipanova@redhat.com over 7 years ago
- Status changed from NEW to POST
- Assignee set to ipanova@redhat.com
Updated by ipanova@redhat.com over 7 years ago
- Status changed from POST to ASSIGNED
Updated by mhrivnak over 7 years ago
We need a smash issue to cover this use case if one doesn't already exist.
Updated by ipanova@redhat.com over 7 years ago
- Status changed from ASSIGNED to POST
- Sprint/Milestone set to 29
Updated by ipanova@redhat.com over 7 years ago
smash issue https://github.com/PulpQE/pulp-smash/issues/443
Added by ipanova@redhat.com over 7 years ago
Added by ipanova@redhat.com over 7 years ago
Revision f6643349 | View on GitHub
Blobs with manifest references should not be removed.
Added by ipanova@redhat.com over 7 years ago
Revision f6643349 | View on GitHub
Blobs with manifest references should not be removed.
Added by ipanova@redhat.com over 7 years ago
Revision f6643349 | View on GitHub
Blobs with manifest references should not be removed.
Updated by ipanova@redhat.com over 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset f66433498847969fa5ae13add5f5bbd45dcac8af.
Updated by rmcgover over 7 years ago
Will you please consider backporting this to pulp-docker 2.0.x ? It affects our servers currently on that major version, and the impact looks potentially severe (data loss/corruption).
Updated by mhrivnak about 7 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
- Platform Release changed from master to 2.12.0
This was released in pulp_docker 2.3.0-1, which was part of 2.12.0. I'm updating this issue to show that.
$ git tag --contains f66433498847969fa5ae13add5f5bbd45dcac8af
pulp-docker-2.3.0-0.1.beta
pulp-docker-2.3.0-1
.
Blobs with manifest references should not be removed.
closes #2441 https://pulp.plan.io/issues/2441