Story #2384
closedAs a user I can sync manifest lists
100%
Description
As a result of this story, Pulp Docker will support manifests lists for sync, publish and copy.
https://docs.docker.com/registry/spec/manifest-v2-2/#manifest-list
To support manifest lists we need to:
1. Manifest list will be a new content type, so a Manifest list model should be defined.
2. During sync always make 3 requests to the registry and in each request set properly the headers( We would need to make 3 requests to support schema 1, schema2 and manifest lists)
- some parts of sync logic should be changed so it would correctly process manifest list and its image manifests
- also some changes would be needed to be done to the copy operation, so it would properly copy referenced image manifests in the list
- also some changes would need to be in the tagging of the manifest, so it would tag properly the manifest list and respect the fact that the tag is unique per repo
3. As a result of 3rd request we will have to save to the DB manifest list
4. Update Tag model, so it would be aware that it references a manifest list. Based on changes, write a migration.
5. Update apache config to set headers for published manifest list directory to reflect the correct Content-Type, similar to existing behavior with schema 1 vs 2
6. Change publish dir structure, so it would add a directory for manifest lists
7. Change the schema of the crane metadata file to add manifest lists
8. Change publish to create the new crane metadata file
9. Release notes and user docs
10. update crane metadata file docs
Related issues
Updated by ipanova@redhat.com about 8 years ago
- Blocked by Story #2099: As a user, I can sync v2 schema manifests added
Updated by ipanova@redhat.com about 8 years ago
I made it blocked by #2099 because of changes needed to be in Tag model
Updated by mhrivnak about 8 years ago
- Tracker changed from Issue to Story
- % Done set to 0
Updated by mhrivnak over 7 years ago
- Copied to Story #2766: As a user I can sync and publish manifest lists added
Updated by bmbouter over 7 years ago
I'm not very familiar with this, but this issue reads like it has all the right parts. +1 to grooming.
Updated by mhrivnak over 7 years ago
- Sprint/Milestone set to 40
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
Updated by ipanova@redhat.com over 7 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ipanova@redhat.com
Updated by ipanova@redhat.com over 7 years ago
- Status changed from ASSIGNED to POST
Added by ipanova@redhat.com over 7 years ago
Added by ipanova@redhat.com over 7 years ago
Revision 5cde929f | View on GitHub
As a user I can sync manifest lists.
Added by ipanova@redhat.com over 7 years ago
Revision 5cde929f | View on GitHub
As a user I can sync manifest lists.
Added by ipanova@redhat.com over 7 years ago
Revision 5cde929f | View on GitHub
As a user I can sync manifest lists.
Updated by ipanova@redhat.com over 7 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset 5cde929fab8760d564d19d8b5dd1c86ae09b7421.
Updated by Ichimonji10 over 7 years ago
There are now automated tests for syncing and publishing Docker manifest lists. The most relevant changes are:
- https://github.com/PulpQE/pulp-smash/pull/724
- https://github.com/PulpQE/pulp-smash/pull/741
- https://github.com/PulpQE/pulp-smash/pull/744
In addition, I've performed some manual testing. The manual testing was as simple as installing Docker, starting the Docker daemon, and executing docker pull localhost:5000/{repo_id}
for several different repositories.
Updated by pcreech over 7 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
As a user I can sync manifest lists.
closes #2384 https://pulp.plan.io/issues/2384