Project

Profile

Help

Task #2343

closed

Update docs & scripts to reflect github review process

Added by semyers about 6 years ago. Updated over 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

After a discussion related to an RFC I posted to pulp-dev, we've decided to stop using the LGTM tag and start using the github review system to approve PRs. While this change has been accepted and is now the expected workflow, we should update the docs to reflect this change, and take advantage of github's protected branch feature's support for this workflow.

This section should be adapted to no longer reference the LGTM tag:
http://docs.pulpproject.org/en/2.9/dev-guide/contributing/merging.html#merging-your-changes

This script should be updated to include review status in branch protection results:
https://github.com/pulp/devel/blob/master/scripts/protect-branches.py

The script's protect_branch function may also have to be updated to yield branches that have protection enabled, but not the correct branch protection settings (e.g. the branch is protected but still allows PR merges without review.

For reference: https://developer.github.com/v3/repos/branches/#update-branch-protection

Actions #1

Updated by semyers about 6 years ago

A small docs update starts to address this, but is really about the addition of the new "Block Release" field:
https://pulp.plan.io/issues/2343

Added by semyers about 6 years ago

Revision b9ddd898

Update bugs guide to use "Blocks Release" field.

Also tweaked the bug reporting steps to better reflect our actually current workflow.

re #2343 https://pulp.plan.io/issues/2343

Added by semyers about 6 years ago

Revision b9ddd898

Update bugs guide to use "Blocks Release" field.

Also tweaked the bug reporting steps to better reflect our actually current workflow.

re #2343 https://pulp.plan.io/issues/2343

Actions #2

Updated by bmbouter over 3 years ago

  • Status changed from NEW to CLOSED - WONTFIX
Actions #3

Updated by bmbouter over 3 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

Actions #4

Updated by bmbouter over 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF