Issue #2315
closedBetter logging at INFO level
Description
Downloads are currently logged at the DEBUG level, but a number of users have requested that they be logged at INFO.
The streamer already logs them at INFO, and a good discussion was had about that behavior where those involved came to consensus. A similar example that comes to mind is MTAs, where each email coming and going normally gets logged at INFO.
This would be done in two modules. HTTPThreadedDownloader and LocalFileDownloader. For example, here are some links to these where DEBUG logging currently takes place:
https://github.com/pulp/nectar/blob/4fe7327c4ad1bb2f8c040b75d80306ee047de615/nectar/downloaders/threaded.py#L267
https://github.com/pulp/nectar/blob/4fe7327c4ad1bb2f8c040b75d80306ee047de615/nectar/downloaders/local.py#L161
Implementation Details¶
It might make more sense to log right before calling the success and failure handlers, but that might miss the download_one workflow. That detail aside, I would imagine something like:
log.info('Download succeeded: {url}')
or
log.info('Download failed: {url}')
Related issues
Better logging at INFO level for downloads
Instead of showing success/error messages at debug level, we're now showing them at INFO. If the error message was at a level above INFO, I left it as is.
fixes #2315 https://pulp.plan.io/issues/2315