Issue #2221
closed
rsync distributor doesn't remove files from remote when rsyncing empty repository with --delete
Description
How to reproduce:
1. create rpm repo with some packages
2. publish in yum
3. publish in rsync distributor
4. remove all rpm units
5. publish in yum
6. publish in rsync distributor with --delete
Actual result: Packages are still on the remote
Expected result: Packages were removed from the remote
See pulp_smash_reproducer.py
Files
Related issues
Updated by amacdona@redhat.com over 7 years ago
- Priority changed from Normal to High
- Severity changed from 2. Medium to 3. High
- Triaged changed from No to Yes
Updated by Ichimonji10 over 7 years ago
An automated test for this issue is being added to Pulp Smash. See: https://github.com/PulpQE/pulp-smash/pull/377
Updated by dkliban@redhat.com over 7 years ago
I was able to reproduce this issue. This only occurs when ALL units are removed from the repository. When only a portion of units are removed, the delete override correctly deletes units from the remote server.
Updated by jluza over 7 years ago
- File 0001-added-packages_directory-option-for-yum_distributor.patch 0001-added-packages_directory-option-for-yum_distributor.patch added
Patch added
Updated by jluza over 7 years ago
- File 0001-skip-rsync-if-there-are-no-files-to-sync-but-also-on.patch 0001-skip-rsync-if-there-are-no-files-to-sync-but-also-on.patch added
I accidentally attached wrong patch. Now the correct patch
Updated by ipanova@redhat.com over 7 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
- Tags 2.11 added
Updated by ipanova@redhat.com over 7 years ago
- Project changed from RPM Support to Pulp
- Status changed from NEW to ASSIGNED
- Assignee set to ipanova@redhat.com
Added by jluza over 7 years ago
Added by jluza over 7 years ago
Revision 3944f724 | View on GitHub
skip rsync if there are no files to sync but also only if delete is False
closes #2221 https://pulp.plan.io/issues/2221
Signed-off-by: Ina Panova ipanova@redhat.com
Updated by ipanova@redhat.com over 7 years ago
- Status changed from ASSIGNED to POST
Updated by ipanova@redhat.com over 7 years ago
Handtested following these steps:
https://github.com/pulp/pulp/pull/2729#issuecomment-244339405
Updated by jluza over 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|3944f72428160682a815a8c7e82625d4f2f3deac.
Updated by ipanova@redhat.com over 7 years ago
- Is duplicate of Issue #2337: The RPM rsync distributor's "delete" option has no effect added
Updated by ipanova@redhat.com over 7 years ago
- Status changed from MODIFIED to CLOSED - DUPLICATE
Updated by ipanova@redhat.com over 7 years ago
- Status changed from CLOSED - DUPLICATE to MODIFIED
Updated by ipanova@redhat.com over 7 years ago
- Is duplicate of deleted (Issue #2337: The RPM rsync distributor's "delete" option has no effect)
Updated by ipanova@redhat.com over 7 years ago
- Has duplicate Issue #2337: The RPM rsync distributor's "delete" option has no effect added
Updated by semyers over 7 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
.
skip rsync if there are no files to sync but also only if delete is False
closes #2221 https://pulp.plan.io/issues/2221
Signed-off-by: Ina Panova ipanova@redhat.com